Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3594 - Email to Student - 2nd Disbursement has passed, still pending (Part 1) #4299

Conversation

lewischen-aot
Copy link
Collaborator

@lewischen-aot lewischen-aot commented Jan 28, 2025

As the first part of the story PR, this PR has the following change:

  • Added DB migration for inserting the record "Student application notification for overdue second disbursement still pending." to the table notificationMessages

Rollback evidence

Screenshot 2025-01-28 093728

Screenshot of the added record to the notificationMessages table
image

@lewischen-aot lewischen-aot added Student Student Features Institution Institution Features DB DB migration involved labels Jan 28, 2025
@lewischen-aot lewischen-aot self-assigned this Jan 28, 2025
@lewischen-aot lewischen-aot changed the title #3594 - Email to Student - 2nd Disbursement has passed, still pending #3594 - Email to Student - 2nd Disbursement has passed, still pending (Part 1) Jan 28, 2025
@lewischen-aot lewischen-aot marked this pull request as ready for review January 28, 2025 18:17
@dheepak-aot dheepak-aot self-requested a review January 28, 2025 21:00
VALUES
(
31,
'Student application notification for overdue second disbursement still pending.',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor observation. Either overdue of second disbursement confirmation or second disbursement still pending alone sounds more clear IMO.

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job @lewischen-aot. Just a minor observation. 👍

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.61% ( 3884 / 17179 )
Methods: 10.41% ( 226 / 2172 )
Lines: 26.01% ( 3350 / 12880 )
Branches: 14.48% ( 308 / 2127 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.14% ( 1249 / 1450 )
Methods: 82.42% ( 136 / 165 )
Lines: 88.51% ( 1032 / 1166 )
Branches: 68.07% ( 81 / 119 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 68.11% ( 6019 / 8837 )
Methods: 65.84% ( 742 / 1127 )
Lines: 71.94% ( 4712 / 6550 )
Branches: 48.71% ( 565 / 1160 )

Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @lewischen-aot 👍

@lewischen-aot lewischen-aot added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 2285eea Jan 28, 2025
21 checks passed
@lewischen-aot lewischen-aot deleted the feature/#3594-email-to-student-2nd-disbursement-has-passed-part-1 branch January 29, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB DB migration involved Institution Institution Features Student Student Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants