#4253 - Upgrade Redis Version and increase Memory - Part 1 #4292
Conversation
| if [ "${{ inputs.action }}" == "install" ]; then | ||
| make install NAMESPACE=${{ secrets.OPENSHIFT_ENV_NAMESPACE }} | ||
| elif [ "${{ inputs.action }}" == "upgrade" ]; then | ||
| PASSWORD=$(oc get secret redis-cluster -n ${{ secrets.OPENSHIFT_ENV_NAMESPACE }} -o jsonpath="{.data.redis-password}" | base64 --decode) |
There was a problem hiding this comment.
Just double-checking, will it not print the Redis password to the GHA execution logs, right?
There was a problem hiding this comment.
What is the output of this one? Is there any change expected?
There was a problem hiding this comment.
There was a problem hiding this comment.
I can see the echo "::add-mask::$PASSWORD" now in the file.
Sharing the GHA dos reference here for future reference: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#masking-a-value-in-a-log
| metrics: | ||
| ## @param metrics.enabled Start a side-car prometheus exporter | ||
| ## | ||
| enabled: false |
There was a problem hiding this comment.
If time allows, can we have the metrics enabled to check the monitoring in sysdig?
There was a problem hiding this comment.
Will verify in the future PR
guru-aot
changed the title
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
andrewsignori-aot
changed the title
andrewsignori-aot
changed the title
guru-aot
deleted the
feature/#4253-Upgrade_Redis_version_and_increase_Memory
branch
| serviceAccount: | ||
| ## @param serviceAccount.create Specifies whether a ServiceAccount should be created | ||
| ## | ||
| create: true | ||
| ## @param serviceAccount.name The name of the ServiceAccount to create | ||
| ## If not set and create is true, a name is generated using the fullname template | ||
| ## | ||
| name: "" |
There was a problem hiding this comment.
As discussed, please check if service account creation is mandatory.
| - ReadWriteOnce | ||
| ## @param persistence.size Size of data volume | ||
| ## | ||
| size: 8Gi |
There was a problem hiding this comment.
As discussed, can't keep the pvc size to 1Gi as it is today?
Team, the below files are copied from bitnami (https://github.com/bitnami/charts/tree/main/bitnami/redis-cluster) for the charts, so please ignore the review on these files below
or in folders
Make file is created for easy installtion of helm charts.
The values.yaml overridden with values from the values-{NAMESPACE}.yaml.
The recommendation values are not given in the https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/ link given, but as per the examples, redis cluster starts at a minimum configuration of Nano where the values are given in this https://github.com/bitnami/charts/blob/main/bitnami/common/templates/_resources.tpl#L15.
I will create a the next PR with the actual values for namespaces values-{NAMESPACE}.yaml.
To enable the github action initial commit of the file is created.
NOTE: Additional file changes
sources/camunda-docker-compose-core.yml - missed network type
sources/packages/forms/Dockerfile.dev is changed to enable development environment login