Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3067 - Assessment History: Update to show most recent assessment #4285

Merged

Conversation

sh16011993
Copy link
Collaborator

@sh16011993 sh16011993 commented Jan 23, 2025

As a part of this PR, the following were completed:

  • Added the TIME (HH:MM 24hr) to the Assessment date in the history view.
  • Ensured that the table is always ordered by submitted date descending.
  • Confirmed that the changes apply to the Ministry view, Student view and the Institution view.

Screenshots:

Institution View:

image

Student View:

image

Ministry View:

image

@sh16011993 sh16011993 self-assigned this Jan 23, 2025
@sh16011993 sh16011993 added Web portal Student Student Features Institution Institution Features Ministry Ministry Features labels Jan 23, 2025
@@ -275,7 +275,7 @@ export class StudentAssessmentService extends RecordDataModelService<StudentAsse
});
}
return assessmentHistoryQuery
.orderBy("assessment.studentAssessmentStatus", "DESC")
.orderBy("assessment.studentAssessmentStatus", "ASC")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the orderBy("assessment.studentAssessmentStatus", "ASC") and keep only the OrderBy("assessment.submittedDate", "DESC") to comply with the business AC.

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.52% ( 3864 / 17159 )
Methods: 10.32% ( 224 / 2170 )
Lines: 25.93% ( 3336 / 12866 )
Branches: 14.32% ( 304 / 2123 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.14% ( 1249 / 1450 )
Methods: 82.42% ( 136 / 165 )
Lines: 88.51% ( 1032 / 1166 )
Branches: 68.07% ( 81 / 119 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 68.11% ( 6019 / 8837 )
Methods: 65.84% ( 742 / 1127 )
Lines: 71.94% ( 4712 / 6550 )
Branches: 48.71% ( 565 / 1160 )

@lewischen-aot lewischen-aot self-requested a review January 24, 2025 22:38
Copy link
Collaborator

@lewischen-aot lewischen-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Nice work

@sh16011993 sh16011993 added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit 39048ae Jan 24, 2025
21 checks passed
@sh16011993 sh16011993 deleted the 3067_assessment_history_update_to_show_most_recent_assessment branch January 24, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Institution Institution Features Ministry Ministry Features Student Student Features Web portal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants