From da5ad057001c751e1a80fa266810836b9da5c1e9 Mon Sep 17 00:00:00 2001 From: Dheepak Ramanathan Date: Thu, 31 Oct 2024 17:51:43 -0600 Subject: [PATCH 1/2] parse the last 2 characters in NEB as decimal places. --- .../src/sfas-integration/sfas-files/sfas-individual-record.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sources/packages/backend/libs/integrations/src/sfas-integration/sfas-files/sfas-individual-record.ts b/sources/packages/backend/libs/integrations/src/sfas-integration/sfas-files/sfas-individual-record.ts index e74d3e0fae..72bf7d561b 100644 --- a/sources/packages/backend/libs/integrations/src/sfas-integration/sfas-files/sfas-individual-record.ts +++ b/sources/packages/backend/libs/integrations/src/sfas-integration/sfas-files/sfas-individual-record.ts @@ -113,7 +113,7 @@ export class SFASIndividualRecord extends SFASRecordIdentification { * Total Nurses Education Bursary (special_program_award.program_awd_cents, award_cde = "SP04"). */ get neb(): number { - return +this.line.substring(131, 141); + return parseDecimal(this.line.substring(131, 141)); } /** * BC Completion Grant for Graduates (individual_award.award_dlr, award_cde = "BCGG"). From a707958fadfb8733b91e5f9d33dfe22594af3b25 Mon Sep 17 00:00:00 2001 From: Dheepak Ramanathan Date: Fri, 1 Nov 2024 09:05:33 -0600 Subject: [PATCH 2/2] E2E test fix --- .../_tests_/sfas-integration.scheduler.e2e-spec.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sources/packages/backend/apps/queue-consumers/src/processors/schedulers/sfas-integration/_tests_/sfas-integration.scheduler.e2e-spec.ts b/sources/packages/backend/apps/queue-consumers/src/processors/schedulers/sfas-integration/_tests_/sfas-integration.scheduler.e2e-spec.ts index e1f538c916..04096aea8e 100644 --- a/sources/packages/backend/apps/queue-consumers/src/processors/schedulers/sfas-integration/_tests_/sfas-integration.scheduler.e2e-spec.ts +++ b/sources/packages/backend/apps/queue-consumers/src/processors/schedulers/sfas-integration/_tests_/sfas-integration.scheduler.e2e-spec.ts @@ -352,7 +352,7 @@ describe(describeProcessorRootTest(QueueNames.SFASIntegration), () => { ppdStatusDate: "1967-07-22", msfaaNumber: "9876543210", msfaaSignedDate: "2024-07-12", - neb: 5000, + neb: 50, bcgg: 5000, lfp: 7560.5, pal: 7560.5, @@ -376,7 +376,7 @@ describe(describeProcessorRootTest(QueueNames.SFASIntegration), () => { ppdStatusDate: null, msfaaNumber: "9876543211", msfaaSignedDate: "2024-07-13", - neb: 5000, + neb: 50, bcgg: 5000, lfp: 11040, pal: 11040,