Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2074 - Fix the store reference #2075

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Conversation

dheepak-aot
Copy link
Collaborator

The store reference was wrong at this part of the code and due to the same, useInstitutionAuth was always returning undefined for isBCPublic.

image

It has been fixed and it is working now.

image

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.89% ( 2127 / 11890 )
Methods: 8.32% ( 126 / 1515 )
Lines: 20.68% ( 1863 / 9008 )
Branches: 10.1% ( 138 / 1367 )

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 49.81% ( 267 / 536 )
Methods: 41.56% ( 32 / 77 )
Lines: 55.33% ( 218 / 394 )
Branches: 26.15% ( 17 / 65 )

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 71% ( 399 / 562 )
Methods: 61.97% ( 44 / 71 )
Lines: 72.97% ( 351 / 481 )
Branches: 40% ( 4 / 10 )

Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You for the fix @dheepak-aot 👍

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

E2E SIMS API Coverage Report

Totals Coverage
Statements: 50.18% ( 3543 / 7061 )
Methods: 45.63% ( 418 / 916 )
Lines: 55.38% ( 2915 / 5264 )
Branches: 23.84% ( 210 / 881 )

Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice catch

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks for the fix.

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dheepak-aot dheepak-aot changed the title Fix the store reference #2074 - Fix the store reference Jul 4, 2023
@dheepak-aot dheepak-aot merged commit 7f6db57 into main Jul 4, 2023
@dheepak-aot dheepak-aot temporarily deployed to DEV July 4, 2023 21:28 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV July 4, 2023 21:29 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV July 4, 2023 21:29 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV July 4, 2023 21:29 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV July 4, 2023 21:29 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV July 4, 2023 21:31 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV July 4, 2023 21:31 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot deleted the bug/#2074-search-institution-bug branch July 5, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants