-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bridge Expansion for SDPR API #4270
Comments
@dheepak-aot Updated the file link and the ACs to show that SAIL app data records wont be changing and dependant data (302) / disbursement data (303) are now different. |
@CarlyCotton for the new record types, SFAS Applicant Dependant and SFAS Disbursement Data we must have it's own unique identifier to identify that particular record. |
@dheepak-aot Updated the ACs and attached the new V2.3 doc with unique keys. |
# SFAS Bridge Data Expansion ## DB Migration - [x] Added new table `sims.sfas_application_dependents` to import Dependents data of SFAS applications. - [x] Added new table `sims.sfas_application_disbursements` to import Disbursements data of SFAS applications. - [x] Added new columns `sims.sfas_individuals` to expand the existing data. - [x] Added new columns `sims.sfas_applications` to expand the existing data. ## Following existing SFAS Tables - [x] No foreign key constraints are enforced on the new tables following existing SFAS tables. - [x] Audit columns for new tables follow the same pattern as existing SFAS tables. - [x] In the new tables, except the primary key and `application_id` all other fields are kept as nullable for the import to be more permissive following the existing SFAS tables. This has been shared with business as well. ## Rollback Evidence - [x] SFAS Applications revert  - [x] SFAS Individuals Revert  - [x] SFAS Application disbursements Revert  - [x] SFAS Application dependents Revert 
# Import of SFAS Application Dependants and SFAS Application Disbursements ## Import - [x] Added file record objects and import services for SFAS Application Dependants and SFAS Application Disbursements. - [x] Updated the existing logic to log process summary warning when the record type is unknown instead of throwing error and aborting the import(existing logic).   ## E2E Tests - [x] Added E2E tests for import of new record types. - [x] Added E2E Test for logging process summary warning on unknown record type in the file.  ## Launch File Update - Launch file updated to include the directory as well in the pattern while running current test file.
…ort (#4316) # SFAS Bridge File - Expand Individual and Application data Import ## Import of extended data - [x] Updated the file record object for `SFAS Individual` and `SFAS Application`. - [x] Updated the data import service for `SFAS Individual` and `SFAS Application`.   ### SFAS Individuals  ### SFAS Applications     ## E2E Test - [x] Created E2E test with almost all the values for `SFAS Individual` and `SFAS Application` import. 
As per the testing done from SFAS file, data type of the following DB columns have been updated. - [x] `sims.sfas_individuals` - column `phone_number` changed to BIGINT. - [x] `sims.sfas_applications` - column `application_number` changed to BIGINT. - [x] `sims.sfas_applications` - column `gross_income_previous_year` changed to NUMERIC(10,2). - [x] Numeric transformer was used wherever required. **Note**: Type casting wasn't used in the data type conversion expecting no data in the columns. ## Rollback Evidence  
@ninosamson @CarlyCotton Bulk file from SFAS has been successfully imported in DEV(Please remember that all 9999999 were replaced by 0999999 in the file to ensure money values are not having junk data). Values loaded into new fields: |
User Story
As a system, SIMS needs to be able to provide up to seven years of application data. This will include SFAS information and we need to include that in the current SFAS to SIMS bridge file.
Acceptance Criteria
SFAS to SIMS Bridge V2.3 DRAFT
New Record Types:
Additional Fields for Individual Records (200) at end of record
Additional Fields for Application Records (300) at end of record
Technical
Note: Currently for SFAS data import, every record type except header has a sims table where it is imported into.
sims.sfas_application_dependents
(302) andsims.sfas_application_disbursements
(303) and the related models.sims.sfas_individuals
andsims.sfas_applications
the related models. All the new fields must be nullable ensuring the backward compatibility.data-importers
and related objects for new record types.The text was updated successfully, but these errors were encountered: