Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Institution Read-Only User Type PART 2 (UI) #4014

Closed
13 tasks done
Joshua-Lakusta opened this issue Nov 29, 2024 · 0 comments
Closed
13 tasks done

Institution Read-Only User Type PART 2 (UI) #4014

Joshua-Lakusta opened this issue Nov 29, 2024 · 0 comments
Assignees
Labels
Enhancement New feature or request Institution Institution Features

Comments

@Joshua-Lakusta
Copy link
Collaborator

Joshua-Lakusta commented Nov 29, 2024

User Story
As an institution user I need to be able to add users that have read only access. Introduce a new user role for all institution accounts which permits read-only capabilities.

Institution stakeholders - in particular BC Public schools - have emphasized that they have large FAO offices with numerous staff, many of whom perform strictly 'advisory' roles to the student, and are not authorized to make any changes which affect a student's application or the school's list of programs and offerings. Given the risks with taking such action, they would prefer the ability to assign a 'read-only' ability to any given user.

Acceptance Criteria:

  • Add a new user role called 'read-only' located between user and no access
  • Update the UI to prevent the actions long the below areas.
    • Prevent user from changing any offering related data
    • 'Complete Program Info Request' button
    • 'Application Action' drop down button on the 'Confirm Enrolment' screen of a particular application
    • 'Submit update' button on the 'report a change' screen of a particular application
    • 'Submit requested change' button on the 'Request an application change' screen of a particular application

image.png

  • Adjust the "Add Users" screen to describe the 'read-only' role

image.png

Technical

  • API: Update API to receive the read-only type for Ministry and Institutions.
  • UI: Add read-only option in Edit User Screen.
    • Ensure buttons are disabled across all mentioned areas in the business ACs.
    • Ensure routes are disallowed if the entire page should not be accessed. For instance, if there is a page dedicated for program creations, it may be completely blocked from the router InstitutionRoutes.
  • E2E Tests
    • API E2E test(s) for adding read-only user.

Context:
Institution users currently have two user types: Admin and User. The user type with the most limited capabilities - a User - still has the ability to add programs and offerings to a particular location within the school, and to make actions to a particular student's account - PIR, COE and Scholastic Standing.

@Joshua-Lakusta Joshua-Lakusta added Business Items under Business Consideration Enhancement New feature or request Institution Institution Features labels Nov 29, 2024
@Joshua-Lakusta Joshua-Lakusta self-assigned this Nov 29, 2024
@Joshua-Lakusta Joshua-Lakusta changed the title Copy of Institution Read-Only User Type Institution Read-Only User Type PART 1 (UI) Nov 29, 2024
@CarlyCotton CarlyCotton changed the title Institution Read-Only User Type PART 1 (UI) Institution Read-Only User Type PART 2 (UI) Dec 3, 2024
@CarlyCotton CarlyCotton added Dev & Architecture Development and Architecture and removed Business Items under Business Consideration labels Dec 3, 2024
@andrewsignori-aot andrewsignori-aot removed the Dev & Architecture Development and Architecture label Jan 2, 2025
@lewischen-aot lewischen-aot self-assigned this Feb 3, 2025
github-merge-queue bot pushed a commit that referenced this issue Feb 10, 2025
As part of the story, this first PR has the following changes:
- Added a new user role called 'read-only' located between user and no
access on the UI.
- Updated the UI to prevent actions in the below areas.
- **Program and Offering**: prevent user from changing any offering
related data
  - **PIR**: 'Complete Program Info Request' button
- **Confirm enrolment**: 'Application Action' drop down button on the
'Confirm Enrolment' screen of a particular application
- **Report a change**: 'Submit update' button on the 'report a change'
screen of a particular application
- **Request a change**: 'Submit requested change' button on the 'Request
an application change' screen of a particular application
- Ensured buttons are disabled across all mentioned areas in the
business ACs.
- Ensured routes are disallowed for **program-creation** and
**offering-creation** pages for read-only-users.
- Adjusted the "Add Users" screen to describe the 'read-only' role

Screenshot of the assign-user-role model
![Screenshot 2025-02-06
114420](https://github.com/user-attachments/assets/5f6d722c-2ec4-4675-bcc7-d645394124eb)

Screenshot of the added item in the list

![image](https://github.com/user-attachments/assets/cb6b70cd-ed81-4c6a-a42a-8a410ae12b0d)
github-merge-queue bot pushed a commit that referenced this issue Feb 11, 2025
As the second part of this story, this PR has the following changes:
- Added E2E tests for the following endpoint methods:
  - createInstitutionUserWithAuth
  - updateInstitutionUserWithAuth
- Added method `mockBCeIDAccountDetails` to mock the response from
method `bceIDService.getAccountDetails` to assist the endpoint method
`createInstitutionUserWithAuth`.

Screenshots of E2E tests

![image](https://github.com/user-attachments/assets/b759d4f1-4dbe-45bc-b88e-9d7381cdcd50)


![image](https://github.com/user-attachments/assets/d3cfbda2-a9dd-4242-8f22-68cffb7a44c8)
lewischen-aot added a commit that referenced this issue Feb 12, 2025
This PR removes the two buttons related to program and offering
executions for read-only users:
- Removed button "+ Create program" on the PIR page.
- Removed dropdown button "Edit offering" on the offering edit page.

Screenshots

![image](https://github.com/user-attachments/assets/55344aaa-5674-4135-8ed6-eb65c386c416)


![image](https://github.com/user-attachments/assets/f4a3e3b4-b3e1-49f5-9f33-c769b1cde94b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Institution Institution Features
Projects
None yet
Development

No branches or pull requests

6 participants