Review Comments

Author: dheepak-aot

Diff for: sources/packages/backend/apps/api/src/route-controllers/user/user.aest.controller.ts

@@ -54,9 +54,9 @@ export class UserAESTController extends BaseController {
     // If the user token is missing any of the primary user information to create a user
     // then throw an error.
     if (
-      !!userToken.userName?.trim() ||
-      !!userToken.email?.trim() ||
-      !!userToken.lastName?.trim()
+      !userToken.userName?.trim() ||
+      !userToken.email?.trim() ||
+      !userToken.lastName?.trim()
     ) {
       throw new BadRequestException(
         new ApiProcessError(

Diff for: sources/packages/web/src/services/UserService.ts

@@ -37,7 +37,7 @@ export class UserService {
    * @returns true if the user was successfully created/updated or
    * false if the user do not have permission to access the system.
    */
-  async syncAESTUser(authHeader?: any): Promise<boolean> {
-    return ApiClient.User.syncAESTUser(authHeader);
+  async syncAESTUser(): Promise<boolean> {
+    return ApiClient.User.syncAESTUser();
   }
 }

Diff for: sources/packages/web/src/services/http/UserApi.ts

@@ -10,7 +10,7 @@ import {
   MISSING_USER_ACCOUNT,
   MISSING_USER_INFO,
 } from "@/constants";
-import { AxiosError } from "axios";
+import { ApiProcessError } from "@/types";
 
 export class UserApi extends HttpBaseClient {
   async bceidAccount(): Promise<BCeIDDetailsAPIOutDTO> {
@@ -45,30 +45,21 @@ export class UserApi extends HttpBaseClient {
    * @returns true if the user was successfully created/updated or
    * false if the user do not have permission to access the system.
    */
-  async syncAESTUser(authHeader?: any): Promise<boolean> {
+  async syncAESTUser(): Promise<boolean> {
     try {
-      await this.apiClient.put(
-        this.addClientRoot("user"),
-        // The data to perform the create/update
-        // will come from the authentication token.
-        null,
-        authHeader ?? this.addAuthHeader(),
-      );
+      await this.putCall(this.addClientRoot("user"), null);
       return true;
     } catch (error: unknown) {
       if (
-        error instanceof AxiosError &&
-        (error.response?.data.errorType === MISSING_USER_ACCOUNT ||
-          error.response?.data.errorType === MISSING_GROUP_ACCESS ||
-          error.response?.data.errorType === MISSING_USER_INFO)
+        error instanceof ApiProcessError &&
+        (error.errorType === MISSING_USER_ACCOUNT ||
+          error.errorType === MISSING_GROUP_ACCESS ||
+          error.errorType === MISSING_USER_INFO)
       ) {
         // If the user do not have a proper authorization
         // an HTTP error will be raised.
         return false;
       }
-      // If it is not an expected error,
-      // handle it the default way.
-      this.handleRequestError(error);
       throw error;
     }
   }

Diff for: sources/packages/web/src/services/http/common/HttpBaseClient.ts

@@ -134,6 +134,21 @@ export default abstract class HttpBaseClient {
     }
   }
 
+  /**
+   * Executes a HTTP request using a PUT verb including the authentication token.
+   * @param url API endpoint URI.
+   * @param payload data to be sent.
+   * @param suppressErrorHandler optionally skip the global error handling.
+   */
+  protected async putCall<T>(url: string, payload: T): Promise<void> {
+    try {
+      await this.apiClient.put(url, payload, this.addAuthHeader());
+    } catch (error: unknown) {
+      this.handleRequestError(error);
+      throw error;
+    }
+  }
+
   protected handleCustomError(error: any) {
     if (error.response) {
       this.handleRequestError(error.response.data?.message);