Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Just expose the sonarqube variables as plaintext, as they are not sec… #4344

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Just expose the sonarqube variables as plaintext, as they are not sec… #4344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/app-react.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,14 @@ jobs:
uses: sonarsource/sonarqube-scan-action@master
env:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
SONAR_HOST_URL: ${{ vars.SONAR_URL }}
PROJECT_KEY: ${{vars.PROJECT_KEY_APP}}
SONAR_HOST_URL: https://sonarqube-3cd915-tools.apps.silver.devops.gov.bc.ca/
PROJECT_KEY: 21faa627-fe70-4a67-89e3-1262a32d2e2c
PROJECT_NAME: PIMS-APP
with:
projectBaseDir: ${{env.working-directory}}
args: >
-Dsonar.projectKey=${{vars.PROJECT_KEY_APP}}
-Dsonar.projectName=${{vars.PROJECT_NAME}}
-Dsonar.projectKey=21faa627-fe70-4a67-89e3-1262a32d2e2c
-Dsonar.projectName=PIMS-APP
-Dsonar.qualitygate.wait=true

# Send notifications only if MS_TEAMS_NOTIFY_URL secret has been set
Expand Down
Loading