Psp 8635, psp-8636, psp-8638 #4104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinleighsmith
commented
Jun 11, 2024
| @@ -92,8 +92,8 @@ export const PointClusterer: React.FC<React.PropsWithChildren<PointClustererProp | |||
| return mapMachine.filePropertyLocations.map(x => { | |||
| // The values on the feature are rounded to the 4th decimal. Do the same to the draft points. | |||
| return { | |||
| lat: parseFloat(x.lat.toFixed(4)), | |||
There was a problem hiding this comment.
this was causing some draft markers to be offset from their parent markers at high zoom levels.
devinleighsmith
commented
Jun 11, 2024
| @@ -11,7 +11,7 @@ | |||
| <id>contact</id> | |||
| </contact> | |||
| <charset>UTF-8</charset> | |||
| <numDecimals>4</numDecimals> | |||
| <numDecimals>8</numDecimals> | |||
There was a problem hiding this comment.
I believe this is the reason the draft markers were being limited to four decimal places - but this restriction only exists on our local geoserver and not the moti one.
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
asanchezr
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commits for story definitions.