correct modal close icon, text. #4015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
eddherrera
approved these changes
May 13, 2024
|
✅ No secrets were detected in the code. |
devinleighsmith
added a commit
that referenced
this pull request
Jun 6, 2024
* Psp 8109 - color palette refactor (#3951) * psp-8109 app color updates. * fix * test corrections. * merge correction. * psp-8109 cleanup, PR feedback. * corrections. * formatting. * snapshots. * 5.3 updates from dev (#3983) * Bump DEV version - IS79 (#3974) * CI: Bump version to v5.2.0-79.1 * psp-7999 close button styling (#3973) Co-authored-by: Alejandro Sanchez <[email protected]> * CI: Bump version to v5.2.0-79.2 * IS-79.00 Database Schema (#3969) * IS-79.00 Database Schema PSP_PIMS | Development Sprint: S79.00 | Design Sprint: 78 | Date: 2024-Apr-23 - Altered tables: - PIMS_ACQUISITION_FILE - PIMS_PROPERTY - Added seed scripts: - 007_PSP_PIMS_ACQUISITION_FILE_HIST_Add.sql - 151_DML_PIMS_FILE_NUMBER_TYPE.sql - Altered seed scripts: - 116_DML_PIMS_TAKE_TYPE.sql - Altered test scripts: - 031_PIMS_ACQUISITION_FILE.sql - 033_PIMS_PROPERTY_ACQUISITION_FILE.sql - 043_PIMS_ACQUISITION_FILE.sql - 058_PIMS_TAKE.sql - Added test scripts: - 075_PIMS_FILE_NUMBER.sql - Requires additional metadata to meet standards * Updated Lease Purpose Codes Late addition to the release. --------- Co-authored-by: Manuel Rodriguez <[email protected]> * CI: Bump version to v5.2.0-79.3 * Scaffold/s79 (#3975) * Generated scaffold * Compilation fixes * CI: Bump version to v5.2.0-79.4 * PSP-8182: Automation update based on last changes on TST Environment (#3976) * Adding or improving list views and pagination * Automation - changes based on Build updates * Deleting unnecessary comments * Subdivision/ Consolidation - Alternative testing paths * Updates based on last deployment to TST environment --------- Co-authored-by: Alejandro Sanchez <[email protected]> Co-authored-by: devinleighsmith <[email protected]> * CI: Bump version to v5.2.0-79.5 * snapshot updates. (#3977) * CI: Bump version to v5.2.0-79.6 * vitest corrections (#3978) * vitest fixes. * re-install moment-timezone. * remove only modifier * snapshot update. * skip failing test. * vitest performance and mocking corrections. * ensure console warnings are treated as failures. * try skipping troublesome test. * acquisition file owners. * CI: Bump version to v5.2.0-79.7 * PSP-8022 : Disposition file states - Hold (#3979) Co-authored-by: Herrera <[email protected]> * CI: Bump version to v5.2.0-79.8 * psp-7909 take ui refactor. (#3980) * psp-7909 take ui refactor. * psp-8145 * correct invalid type. * code review corrections. * merge corrections. * CI: Bump version to v5.2.0-79.9 * unit test stability corrections (#3982) * vitest fixes. * re-install moment-timezone. * vitest performance and mocking corrections. * ensure console warnings are treated as failures. * try skipping troublesome test. * update msw, make some corrections to aid with test instability. * increase maxworkers now that test stability increased. * package updates. * CI: Bump version to v5.2.0-79.10 * snapshots --------- Co-authored-by: Alejandro Sanchez <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Doug Filteau <[email protected]> Co-authored-by: Manuel Rodriguez <[email protected]> Co-authored-by: Sue Tairaku <[email protected]> Co-authored-by: Eduardo <[email protected]> Co-authored-by: Herrera <[email protected]> * psp-5489 | Lease header historical numbers (#3990) * added backend and frontend components * Regenerated snaps * psp-7861 Historical file numbers on Acquisition file and Research file (#4000) * added backend and frontend components * Regenerated snaps * Addes historical numbers to the acq and research headers * Updated snaps * Manual merge * 5.3 test fixes (#4007) * CI: Bump version to v5.2.0-79.27 * Bump DEV version to 5.3 (#4008) * CI: Bump version to v5.3.0-80.1 * PSP-8444: Update on Automated Takes (#4011) * Adding or improving list views and pagination * Automation - changes based on Build updates * Deleting unnecessary comments * Subdivision/ Consolidation - Alternative testing paths * Updates based on last deployment to TST environment * Changes on automation based on IS79 changes * Takes update * Takes update --------- Co-authored-by: Alejandro Sanchez <[email protected]> Co-authored-by: devinleighsmith <[email protected]> * CI: Bump version to v5.3.0-80.2 * IS-80.00 Database Schema (#3999) * IS-80.00 Database Schema PSP_PIMS | Development Sprint: S80.00 | Design Sprint: 79 | Date: 2024-May-07 - Added tables: - PIMS_HISTORICAL_FILE_NUMBER - PIMS_HISTORICAL_FILE_NUMBER_HIST - PIMS_HISTORICAL_FILE_NUMBER_TYPE - Altered tables: - PIMS_INSURANCE - PIMS_LEASE - PIMS_LEASE_HIST - PIMS_PROPERTY - Dropped tables: - PIMS_FILE_NUMBER - PIMS_FILE_NUMBER_HIST - PIMS_FILE_NUMBER_TYPE - Added views: - PIMS_HISTORICAL_FILE_NUMBER_VW - PIMS_PROPERTY_VW - Altered views: - PIMS_PROPERTY_BOUNDARY_VW - PIMS_PROPERTY_LOCATION_VW - Added seed scripts: - 151_DML_PIMS_HISTORICAL_FILE_NUMBER_TYPE.sql - Altered seed scripts: - 072_DML_PIMS_INSURANCE_TYPE.sql - 073_DML_PIMS_LEASE_STATUS_TYPE.sql - 083_DML_PIMS_RESEARCH_FILE_STATUS_TYPE.sql - 138_DML_PIMS_DISPOSITION_FILE_STATUS_TYPE.sql - Added test scripts: - 075_HISTORICAL_PIMS_FILE_NUMBER.sql - Altered test scripts: - 033_PIMS_PROPERTY_ACQUISITION_FILE.sql - 031_PIMS_ACQUISITION_FILE.sql - 043_PIMS_ACQUISITION_FILE.sql - 060_PIMS_DISPOSITION_FILE.sql - Requires additional metadata to meet standards * Deleted 151_DML_PIMS_FILE_NUMBER_TYPE.sql * Deleted Schema Compare from LATEST Alter Down * Deleted Non-Historical File Number Test Data Script --------- Co-authored-by: Manuel Rodriguez <[email protected]> * CI: Bump version to v5.3.0-80.3 * Scaffold for s80 and compilation fixes (#4017) * Generated scaffold * Fixed compilation issues * CI: Bump version to v5.3.0-80.4 * correct modal close icon, text. (#4015) * correct modal close icon, text. * snapshot updates. --------- Co-authored-by: Alejandro Sanchez <[email protected]> * CI: Bump version to v5.3.0-80.5 * Added historical file numbers to the disposition header (#4012) Co-authored-by: Alejandro Sanchez <[email protected]> * CI: Bump version to v5.3.0-80.6 * PSP-8256 : Remove PS and LIS number from lease/area (#4013) Co-authored-by: Herrera <[email protected]> * CI: Bump version to v5.3.0-80.7 * PSP-8225 : Adjust "historical file number" on the lease/license search to search across all Historical Numbers (#4010) Co-authored-by: Herrera <[email protected]> * CI: Bump version to v5.3.0-80.8 * Updated lease header files and initial work on other file headers * Psp 8313 - display lease file association updates. (#4014) * psp-8313 Display lease file associations. * Update based on question in story - certain tenant types need not be displayed. * CI: Bump version to v5.3.0-80.9 * PSP-5492 Update Historical # and Type on Property Details (Property Attributes) (#4016) * Update frontend service calls to API * Add new type code dropdown * Update historical numbers - frontend * Save the list of historical file numbers * Clear associated fields when historical file number type is changed * Controller, service and repository changes for updating historical numbers * Test updates * Update form validation rules * Test corrections * Fix merge conflicts * Lint fixes * CR feedback * Fix model mappings * Fix lookup table key * CI: Bump version to v5.3.0-80.10 * Initial changes to fruther improve headers * Fixed property zoom on property header * Updated property header * PSP-6900 * snapshots update * CI: Bump version to v5.3.0-80.11 * PSP-7493 lease insurance UI cleanup (#4024) * Lease insurance UI/IX cleanup * Test corrections * Update lease insurance view based on BA feedback * Test corrections * Fix merge conflicts * CR feedback * CI: Bump version to v5.3.0-80.12 * psp-5511 display mayan document previews. (#4009) * psp-5511 display mayan document previews. * code review updates. --------- Co-authored-by: Smith <[email protected]> * CI: Bump version to v5.3.0-80.13 * Updated lease header files and initial work on other file headers (#4018) * CI: Bump version to v5.3.0-80.14 * Manual merge and renegerated snaps * psp-7417 add health checks for Major pims services. (#4025) * psp-7417 add health checks for Major pims services. * remove mocked auth code. * CI: Bump version to v5.3.0-80.15 * PSP-8314 : Record reason for rejecting or terminating a lease (#4023) Co-authored-by: Herrera <[email protected]> * CI: Bump version to v5.3.0-80.16 * proposal - styled modal that warns the user is leaving a form. (#3966) Co-authored-by: Smith <[email protected]> * CI: Bump version to v5.3.0-80.17 * CI: Bump version to v5.3.0-80.18 * CI: Bump version to v5.3.0-80.19 * psp-8228 | Updated header status display (#4028) * Added generic status component for headers * Updated tests * CI: Bump version to v5.3.0-80.20 * psp-8415 correct permissions on insurance controller. (#4027) Co-authored-by: Smith <[email protected]> * CI: Bump version to v5.3.0-80.21 * psp-8185 remove closebutton generic modal prop - show custom pims clo… (#4026) * psp-8185 remove closebutton generic modal prop - show custom pims close button by default. * fix notes spacing. --------- Co-authored-by: Smith <[email protected]> Co-authored-by: Alejandro Sanchez <[email protected]> * CI: Bump version to v5.3.0-80.22 * CI: Bump version to v5.3.0-80.23 * PSP-4089 FT-REG: Property Info - When getting a Land Parcel Type that is not defined by PIMS, on edit mode, should display the default option as "Unknown" (#4032) * Update api models * Lint fixes * Set property type to UNKNOWN for disabled code values * CI: Bump version to v5.3.0-80.24 * Psp-8424 download animation correction - also unrelated eslint fix. (#4030) * correct download loading animation. * style corrections psp-8424 * snapshot updates. --------- Co-authored-by: Alejandro Sanchez <[email protected]> * CI: Bump version to v5.3.0-80.25 * Psp 8486 ensure organizations are displayed in file association tenants for leases. (#4031) * psp-8486 ensure orgs display in file associations. * correct display of error icon, ensure that re-loading an errored page removes the error. * snapshot updates. * CI: Bump version to v5.3.0-80.26 * Fixed lease warning not showing (#4038) * CI: Bump version to v5.3.0-80.27 * CI: Bump version to v5.3.0-80.28 * Bump DEV version - IS81 (#4041) * CI: Bump version to v5.3.0-81.1 * PSP-8114 : Expose Mayan errors to frontend (temporarily) (#3972) * CI: Bump version to v5.3.0-81.2 * UI/improvements (#4036) * Removed repeated styles and improved padding * Updated input to match styled mocups and icons * Updated Styling for multiselect and contact input * linting * Regenerated snaps * Updated remove button alignment on project subform * CI: Bump version to v5.3.0-81.3 * Automation test cases update based on IS80 * IS-81.00 Database Schema (#4034) * IS-81.00 Database Schema PSP_PIMS | Development Sprint: S81.00 | Design Sprint: 80 | Date: 2024-May-22 - Added tables: - PIMS_LEASE_CHECKLIST_ITEM - PIMS_LEASE_CHECKLIST_ITEM_HIST - PIMS_LEASE_CHKLST_ITEM_STATUS_TYPE - PIMS_LEASE_CHKLST_ITEM_TYPE - Altered tables: - PIMS_LEASE - Added seed scripts: - 152_DML_PIMS_LEASE_CHKLST_SECTION_TYPE.sql - 153_DML_PIMS_LEASE_CHKLST_ITEM_TYPE.sql - 154_DML_PIMS_LEASE_CHKLST_ITEM_STATUS_TYPE.sql - Altered seed scripts: - 072_DML_PIMS_INSURANCE_TYPE.sql - 049_DML_PIMS_DATA_SOURCE_TYPE.sql - Added test scripts: - 076_PIMS_PIMS_LEASE_CHECKLIST_ITEM.sql - Altered test scripts: - 033_PIMS_PROPERTY_ACQUISITION_FILE.sql - Requires additional metadata to meet standards * Updated IS-81 Database Schema * Updated build. Removed Historical file number # from LIS and PS --------- Co-authored-by: Manuel Rodriguez <[email protected]> * CI: Bump version to v5.3.0-81.4 * Automation test cases update based on IS80 * PSP-8501 * Generated scaffold for s81 (#4047) * CI: Bump version to v5.3.0-81.5 * PSP-8227 : Add search for "historical file number" on the property se… (#4033) Co-authored-by: Herrera <[email protected]> * CI: Bump version to v5.3.0-81.6 * updated lease tenant page (#4044) * CI: Bump version to v5.3.0-81.7 * CI: Bump version to v5.3.0-81.8 * CI: Bump version to v5.3.0-81.9 * Areas fields displaying at most 4 decimals * PSP-8543 : update appsettings files so that a default is provided for Mayan__ExposeErrors (#4053) Co-authored-by: Herrera <[email protected]> * CI: Bump version to v5.3.0-81.10 * snapshots update * updating unit test cases * psp-8531 correct the disposition header icon (#4056) Co-authored-by: Smith <[email protected]> * CI: Bump version to v5.3.0-81.11 * Test case update * CI: Bump version to v5.3.0-81.12 * pims document preview - stability. (#4039) * CI: Bump version to v5.3.0-81.13 * psp-8549 correct property header retired status styling. (#4060) * CI: Bump version to v5.3.0-81.14 * psp-8470 tooltip for lease statuses. (#4058) * CI: Bump version to v5.3.0-81.15 * psp-8534 add 'file:' in front of status on file headers. (#4057) Co-authored-by: Smith <[email protected]> Co-authored-by: Alejandro Sanchez <[email protected]> * CI: Bump version to v5.3.0-81.16 * Psp 8099 - allow special instruction whitespace to display. (#4043) * CI: Bump version to v5.3.0-81.17 * psp-8545 property ownership filter fixes. (#4054) * prevent automatic refresh of secondary ownership filter. * test fixes --------- Co-authored-by: Smith <[email protected]> Co-authored-by: Alejandro Sanchez <[email protected]> * CI: Bump version to v5.3.0-81.18 * psp-5576 update select all button behaviour, ensure paged selections are not lost. (#4059) Co-authored-by: Smith <[email protected]> Co-authored-by: Alejandro Sanchez <[email protected]> * CI: Bump version to v5.3.0-81.19 * psp-8477 - use fully attributed parcel map. (#4046) * psp-8477 - use fully attributed parcel map. * display a warning if the siteminder session expires. * snapshot updates. * snapshot updates. * code review corrections. * CI: Bump version to v5.3.0-81.20 * PSP-8555: Update .NET sonarscanner in GitHub actions to support .NET 8 (#4064) * Update sonar-scanner to support .NET 8 * Linting * CI: Bump version to v5.3.0-81.21 * psp-8108 style changes for improvements page. (#4066) Co-authored-by: Smith <[email protected]> * CI: Bump version to v5.3.0-81.22 * make the file pretext on file headers in front of file status bold. (#4067) Co-authored-by: Smith <[email protected]> * CI: Bump version to v5.3.0-81.23 * PSP-8552 : FT: Map View- Historical file number search is not working… (#4065) Co-authored-by: Herrera <[email protected]> * CI: Bump version to v5.3.0-81.24 * modify tooltip render direction to avoid clipping. (#4069) * modify tooltip render direction to avoid clipping. * also correct remarks section. --------- Co-authored-by: Smith <[email protected]> * CI: Bump version to v5.3.0-81.25 * psp-8499 | Updated historical number rendering for leases (#4050) * Updated historical number rendering for leases * Fixed tests * Updated placeholder and duplicate logic for Historical File # * CI: Bump version to v5.3.0-81.26 * Features/psp 7494 (#4068) * Updated the deposts page * Fixed stylings for buttons and margin for collapsable section * updated snaps * PR comment updates. --------- Co-authored-by: FuriousLlama <[email protected]> Co-authored-by: Smith <[email protected]> Co-authored-by: Alejandro Sanchez <[email protected]> * CI: Bump version to v5.3.0-81.27 * PSP-8315 : Add Lease and License Checklist (#4062) Co-authored-by: Herrera <[email protected]> * CI: Bump version to v5.3.0-81.28 * psp-8585 display either retired or disposed status in property header… (#4075) * psp-8585 display either retired or disposed status in property header if relevant Signed-off-by: devinleighsmith <[email protected]> * psp-8585 code review corrections --------- Signed-off-by: devinleighsmith <[email protected]> * CI: Bump version to v5.3.0-81.29 * psp-8568 fix database scripts such that the draft disposition status is actually disabled. (#4076) * CI: Bump version to v5.3.0-81.30 * PSP-8587 table pagination visual bug (#4078) * PSP-8587 Fix table pagination visual bug * Update snapshots * CI: Bump version to v5.3.0-81.31 * PSP-8586 : FT-REG: Subdivision/ Consolidation - Menu icon enlarges when user clicks on expand the left menu section (#4077) Co-authored-by: Herrera <[email protected]> * CI: Bump version to v5.3.0-81.32 * PSP-8536: Property Information Details - Historical File, Headers. (#4071) * Adding or improving list views and pagination * Automation - changes based on Build updates * Deleting unnecessary comments * Subdivision/ Consolidation - Alternative testing paths * Updates based on last deployment to TST environment * Changes on automation based on IS79 changes * Takes update * Takes update * Changes in Property Details - Historical File and Headers --------- Co-authored-by: Alejandro Sanchez <[email protected]> Co-authored-by: devinleighsmith <[email protected]> * CI: Bump version to v5.3.0-81.33 * psp-8586 auto-format corrections. (#4082) * CI: Bump version to v5.3.0-81.34 * CI: Bump version to v5.3.0-81.35 --------- Signed-off-by: devinleighsmith <[email protected]> Co-authored-by: devinleighsmith <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Doug Filteau <[email protected]> Co-authored-by: Manuel Rodriguez <[email protected]> Co-authored-by: Sue Tairaku <[email protected]> Co-authored-by: Eduardo <[email protected]> Co-authored-by: Herrera <[email protected]> Co-authored-by: Sue Tairaku <[email protected]> Co-authored-by: Smith <[email protected]> Co-authored-by: devinleighsmith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.