Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: revise parameters, improve error handling and checks #51

Merged
merged 30 commits into from
Sep 21, 2023
Merged

feat: revise parameters, improve error handling and checks #51

merged 30 commits into from
Sep 21, 2023

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Sep 19, 2023 •
edited
Loading

  • deprecate and instruct for penetration_test_artifact
  • deprecate and instruct for penetration_test_issue
  • new param name for app penetration test objects
  • new param penetration_test_token for overriding the default token (e.g. P.A.T.)
  • revise URL_HOST_PATH logic
  • add set -eu for errors/stops
  • improved conditionals/checks
  • add issue creation to tests
  • add verification_path to tests
  • dial down required token permissions
  • use runner ubuntu-latest consistently/exclusively

@DerekRoberts DerekRoberts marked this pull request as draft September 20, 2023 05:40
@DerekRoberts DerekRoberts self-assigned this Sep 20, 2023
@DerekRoberts DerekRoberts added the enhancement New feature or request label Sep 20, 2023
mishraomp
mishraomp approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@mishraomp mishraomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noyce

@DerekRoberts DerekRoberts changed the title feat: reduce parameters feat: revise parameters, improve error handling and checks Sep 20, 2023
@DerekRoberts DerekRoberts marked this pull request as ready for review September 21, 2023 00:45
@DerekRoberts DerekRoberts merged commit 39db7a2 into main Sep 21, 2023
@DerekRoberts DerekRoberts deleted the feat/params branch September 21, 2023 01:06
@DerekRoberts DerekRoberts mentioned this pull request Sep 21, 2023
Closed
@DerekRoberts DerekRoberts linked an issue Sep 21, 2023 that may be closed by this pull request
feat: prevent redundant ZAP issue comments bcgov/quickstart-openshift#1324
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishraomp mishraomp mishraomp approved these changes

Assignees

@DerekRoberts DerekRoberts

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: prevent redundant ZAP issue comments
2 participants
@DerekRoberts @mishraomp