Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change add_label_column!() argument list #70

Closed
AshlinHarris opened this issue May 12, 2022 · 0 comments · Fixed by #73
Closed

Change add_label_column!() argument list #70

AshlinHarris opened this issue May 12, 2022 · 0 comments · Fixed by #73
Assignees

Comments

@AshlinHarris
Copy link
Contributor

Running add_label_column!(df1::DataFrame,df2::DataFrame,s::Symbol) interprets s as the ID column shared by df1 and df2. I think it makes more sense to interpret this as the label column of df2. In practice, df2 will have many extraneous columns, so this the label ID should always be specified. In contrast, the ID column can often be inferred as the first column of df, or one with an ID label.

@AshlinHarris AshlinHarris self-assigned this May 16, 2022
@AshlinHarris AshlinHarris linked a pull request May 17, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant