-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [BUG]: default handle styles don't correctly adjust handle positions to center on borders if handle size is changed #690
Comments
Thanks for the report, I'll see what can be done :) |
As this kinda constitutes a breaking change, I will hold off releasing the PR for this until the release of |
@snoozbuster |
hey @bcakmakoglu. Long time no chat. I am wondering if waiting for a major version release for this is really necessary given this more significant breaking change introduced in a minor version, and this quite significant breaking change introduced in a patch version. By comparison, this is much less breaking than either of those changes. |
I'll probably add it earlier since 2.0.0 will take a while do finish. |
I'll put this into 1.29.0 probably ^^ |
Fixed in |
Is there an existing issue for this?
Current Behavior
Handles are only centered on the edges of the nodes if the handles size are not changed
Expected Behavior
Handles are centered on the edges of the nodes regardless of the size of the handle
Steps To Reproduce
set up VueFlow with the additional style
Observe that handles are no longer centered on the edges of the nodes.
Relevant log output
No response
Anything else?
the handle styles are all hard-coded to adjust handles by -4px in the opposite direction, instead of using
translate
. For example, code like this works (to my knowledge) for all sizes of handle:I would have just opened this PR myself but I'm not familiar enough with the various styles and configuration options to be sure that this doesn't break something I haven't discovered.
The text was updated successfully, but these errors were encountered: