Provide JavaInfo so jarjar targets can be a dep of scala targets. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnynek
approved these changes
Jul 28, 2018
| @@ -7,6 +7,11 @@ def _jar_jar_impl(ctx): | |||
| progress_message="jarjar %s" % ctx.label, | |||
| arguments=["process", ctx.file.rules.path, ctx.file.input_jar.path, ctx.outputs.jar.path]) | |||
|
|
|||
| return JavaInfo( | |||
There was a problem hiding this comment.
I think if we do providers like this we might also want to return DefaultInfo with the outputs.jar as well.
Want to follow up with that? (Note you can return a list of providers)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of rules_scala require that dependencies return JavaInfo: https://github.com/bazelbuild/rules_scala/pull/523/files#diff-3830e6e26d863974d38e511b04761916R36
This adds a
JavaInfoto jar_jar rule so scala targets can depend on them.