Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi-release jars #28

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Jan 8, 2023

Versioned classes are shaded based on their class name rather than their full path, which includes a version prefix that must be preserved.

All other processors still apply to the full jar entry path.

Versioned classes are shaded based on their class name rather than their
full path, which includes a version prefix that must be preserved.

All other processors still apply to the full jar entry path.
@fmeum fmeum marked this pull request as ready for review January 8, 2023 14:21
@johnynek
Copy link
Collaborator

johnynek commented Jan 8, 2023

thanks for the PR. I'll review tomorrow.

@fmeum
Copy link
Contributor Author

fmeum commented Jan 20, 2023

@johnynek Friendly ping

Copy link
Collaborator

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks right to me, but it would be great to add a test if you have time.

I'll go ahead and merge however (we can revert/fix if we discover an issue with tests).

@johnynek johnynek merged commit 857fc19 into bazeltools:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants