Make available inline rules directly in the jar_jar rule. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to put the rule in the BUILD instead of having a separate file for the rules.
johnynek
reviewed
May 28, 2022
|
@johnynek I've updated the documentation to explain the |
johnynek
approved these changes
Jun 3, 2022
|
Thanks for doing this! This looks really great, especially as you say for macros. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to put the rule in the BUILD instead of having a separate file for the rules. This creates the file to hold the filtering rule in the sandbox, instead of in the source tree.
This is particularly useful when calling
jar_jarfrom a macro, when you don't want to dynamically create files in the source tree to hold a temporarily created rule file.