Use jar from java runtime and not local_jdk #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anchlovi would love your thoughts here |
|
@beala-stripe if you're using scala_binary/repl/test (as opposed to java_binary) you can take a look at this solution. It requires copying the stub to your workspace. |
|
Thanks! I'll try to find some time to test this out later. |
|
@johnynek this is ready apart from the fact that I'd like to serve the stub from a public place and use http_archive |
Work around and somewhat prepare for resolution of bazelbuild/bazel#6955
|
@johnynek any thoughts or objections? |
johnynek
approved these changes
Mar 27, 2019
|
Thanks @ittaiz |
|
Thank you!
…On Wed, 27 Mar 2019 at 18:10 P. Oscar Boykin ***@***.***> wrote:
Thanks @ittaiz <https://github.com/ittaiz>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#720 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABUIF6ChAeNv898VmkwamRiX475TYqgGks5va5fegaJpZM4cBYHc>
.
|
joshrosen-stripe
added a commit
to joshrosen-stripe/bazel
that referenced
this pull request
Jul 10, 2019
…a#720 Specifically, see the updated file in bazelbuild/rules_scala@1c21fab
gergelyfabian
pushed a commit
to gergelyfabian/rules_scala
that referenced
this pull request
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around and somewhat prepare for resolution of
bazelbuild/bazel#6955