Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for --nolegacy_external_runfiles #1681

Closed
UebelAndre opened this issue Nov 30, 2022 · 1 comment · Fixed by #1790
Closed

Add support for --nolegacy_external_runfiles #1681

UebelAndre opened this issue Nov 30, 2022 · 1 comment · Fixed by #1790
Labels
enhancement

Comments

@UebelAndre
Copy link
Collaborator

--nolegacy_external_runfiles can be very helpful by improving sandbox performance by reducing the number of runfiles produced by executables. It would be great if rules_rust could fully support this flag.
@UebelAndre
Copy link
Collaborator Author

The repo mostly works with this flag but there's some issues with rust_doc_test and crates_vendor (crate_universe rule). I've opened #1680 to address the crates_vendor issue but rust_doc_test is a bit more nuanced and requires a deeper look

@UebelAndre UebelAndre mentioned this issue Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added support for --nolegacy_external_runfiles to rust_doc_test UebelAndre/rules_rust
1 participant
@UebelAndre