Skip to content

Commit f2b9a04

Browse files
committed
use -msvc variant on Windows
Both the standard Rust installer, and rust_repositories() in this repo default to the -msvc platform. Since it is the default on Windows, this change comments out the -gnu variant instead. This change (along with some fixes in cargo raze) allows crates with msvc-specific build deps to compile. I do not know enough about Bazel to say if it will have any unintended side effects, but it seems to work for me.
1 parent e64700d commit f2b9a04

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

rust/platform/platform.bzl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,16 @@ load(
1111
# All T1 Platforms should be supported, but aren't, see inline notes.
1212
_SUPPORTED_T1_PLATFORM_TRIPLES = [
1313
"i686-apple-darwin",
14-
"i686-pc-windows-gnu",
14+
"i686-pc-windows-msvc",
1515
"i686-unknown-linux-gnu",
1616
"x86_64-apple-darwin",
17-
"x86_64-pc-windows-gnu",
17+
"x86_64-pc-windows-msvc",
1818
"x86_64-unknown-linux-gnu",
1919
# N.B. These "alternative" envs are not supported, as bazel cannot distinguish between them
2020
# and others using existing @platforms// config_values
2121
#
22-
#"i686-pc-windows-msvc",
23-
#"x86_64-pc-windows-msvc",
22+
#"i686-pc-windows-gnu",
23+
#"x86_64-pc-windows-gnu",
2424
]
2525

2626
# Some T2 Platforms are supported, provided we have mappings to @platforms// entries.

0 commit comments

Comments
 (0)