-
-
Notifications
You must be signed in to change notification settings - Fork 583
Drop Python 2 support #886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Note: there are a few |
posterity/update: the PR is ready to merge and it'll be merged in January after the holidays. We're also going to cut one last release before it is merged. |
Fail for py2 python_version, srcs_version, and runtime values. See #886
Actually, small change of plans: I've merged this in now with #887. If it turns out to be too problematic, we can revert it for now and attempt again after the holidays. In the meantime, we'll find out about any issues sooner rather than later. |
It has been deprecated for a long time and Bazel 8.0.0 does not support registering a python2 toolchain by default. So let's delete it. Bug: 372860136 Link: bazel-contrib/rules_python#886 Change-Id: I129d864f2c8343e2e821622b20a039679070de26
It has been deprecated for a long time and Bazel 8.0.0 does not support registering a python2 toolchain by default. So let's delete it. Bug: 372860136 Link: bazel-contrib/rules_python#886 Change-Id: I129d864f2c8343e2e821622b20a039679070de26
It has been deprecated for a long time and Bazel 8.0.0 does not support registering a python2 toolchain by default. So let's delete it. Bug: 372860136 Link: bazel-contrib/rules_python#886 Change-Id: I129d864f2c8343e2e821622b20a039679070de26
It has been deprecated for a long time and Bazel 8.0.0 does not support registering a python2 toolchain by default. So let's delete it. Bug: 372860136 Link: bazel-contrib/rules_python#886 Change-Id: I129d864f2c8343e2e821622b20a039679070de26
It has been deprecated for a long time and Bazel 8.0.0 does not support registering a python2 toolchain by default. So let's delete it. Bug: 372860136 Link: bazel-contrib/rules_python#886 Change-Id: I129d864f2c8343e2e821622b20a039679070de26
It has been deprecated for a long time and Bazel 8.0.0 does not support registering a python2 toolchain by default. So let's delete it. Bug: 372860136 Link: bazel-contrib/rules_python#886 Change-Id: I129d864f2c8343e2e821622b20a039679070de26
It has been deprecated for a long time and Bazel 8.0.0 does not support registering a python2 toolchain by default. So let's delete it. Bug: 372860136 Link: bazel-contrib/rules_python#886 Change-Id: I129d864f2c8343e2e821622b20a039679070de26
It has been deprecated for a long time and Bazel 8.0.0 does not support registering a python2 toolchain by default. So let's delete it. Bug: 372860136 Link: bazel-contrib/rules_python#886 Change-Id: I129d864f2c8343e2e821622b20a039679070de26
It has been deprecated for a long time and Bazel 8.0.0 does not support registering a python2 toolchain by default. So let's delete it. Bug: 372860136 Link: bazel-contrib/rules_python#886 Change-Id: I129d864f2c8343e2e821622b20a039679070de26
It has been deprecated for a long time and Bazel 8.0.0 does not support registering a python2 toolchain by default. So let's delete it. Bug: 372860136 Link: bazel-contrib/rules_python#886 Change-Id: I129d864f2c8343e2e821622b20a039679070de26
This is the general tracking issue for removing Python 2 support in rules_python.
For the bazel-side of things, see bazelbuild/bazel#15684
Right now, Python 2 support is defacto not present because...
pip_parse
doesn't work with Python 2However, several of our apis still accept e.g.
python_version=PY2
orsrc_version=PY2|PY2ONLY
, which technically do allow Python 2. We'll be disabling and breaking those.If you want to continue to use rules_python with Python 2, then you will need to use an earlier release and/or fork.
TODO list
python_version
andsrcs_version
values that are Python 2py_runtime_pair.py2_runtime
is setPYTHON2
make var (seecurrent_py_toolchain
)The text was updated successfully, but these errors were encountered: