Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: allow pkg_filegroups to contain pkg_filegroups #429

Closed
kwc opened this issue Oct 5, 2021 · 2 comments
Closed

Feature Request: allow pkg_filegroups to contain pkg_filegroups #429

kwc opened this issue Oct 5, 2021 · 2 comments

Comments

@kwc
Copy link
Contributor

kwc commented Oct 5, 2021

Currently, pkg_filegroup rules can only be aggregated by a pkg_tar rule. I would like to be able to aggregate pkg_filegroup rules with another pkg_filegroup rule -- i.e., I would to specify pkg_filegroup rules as srcs to another pkg_filegroup.

Use case: Due to Bazel incompatible target skipping, we provide explicit targets in our CI testing. I would prefer to test our deployment build with a pkg_filegroup target, but I instead have to test with a pkg_tar target, which adds expensive disk I/O. I would test with multiple pkg_filegroup targets, but this means maintaining the aggregated lists in two places.

With rules_pkg 0.5.1 I get this error if I try to aggregate pkg_filegroup rules:

<target name> does not have mandatory providers: 'PackageFilesInfo' or 'PackageDirsInfo' or 'PackageSymlinkInfo'
@nacl
Copy link
Collaborator

nacl commented Oct 5, 2021

This should already be addressed in main as of 8d54276. Please try it out and confirm whether it works for you.

@nacl nacl added the duplicate label Oct 11, 2021
@nacl
Copy link
Collaborator

nacl commented Oct 11, 2021

Closing; duplicate of #415. Please comment if you do not believe this is the case.

@nacl nacl closed this as completed Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants