chore: move karma_web_test to concatjs #2313
Conversation
BREAKING CHANGE:
`packages/karma:package.bzl` is gone, in your WORKSPACE replace
```
load("//packages/karma:package.bzl", "npm_bazel_karma_dependencies")
npm_bazel_karma_dependencies()
```
with the equivalent
```
http_archive(
name = "io_bazel_rules_webtesting",
sha256 = "9bb461d5ef08e850025480bab185fd269242d4e533bca75bfb748001ceb343c3",
urls = ["https://github.com/bazelbuild/rules_webtesting/releases/download/0.3.3/rules_webtesting.tar.gz"],
)
```
Then in BUILD files replace
`load("@npm//@bazel/karma:index.bzl", "karma_web_test_suite")`
with
`load("@npm//@bazel/concatjs:index.bzl", "concatjs_web_test_suite")`
finally drop npm dependencies on `@bazel/karma` and depend on `@bazel/concatjs` instead
alexeagle
requested review from
alan-agius4,
gregmagolan,
mattem,
mrmeku and
soldair
as code owners
|
Do we not want to keep "karma" in the name somewhere since these rules are karma specific? It's also a bit odd having |
|
@jbedard I think we discussed this plan in a meeting. I agree with those points but do you have an alternative proposal? |
|
No I don't, I guess we should just think of this package as "old g3 concatjs stuff", karma included, instead of a generic concatjs package. That's probably what we already decided though... |
|
Decided to move but not rename the rule |
|
As someone who is just digging around and trying to get |
|
The karma implementation here is indeed coupled with concatjs as the bundler. You could use the vanilla karma js tool under Bazel without any custom rules. |
|
Thank you, that's actually really helpful. I was starting to think the same but it's nice to confirm |
4 participants
BREAKING CHANGE:
packages/karma:package.bzlis gone, in your WORKSPACE replacewith the equivalent
Then in BUILD files replace
load("@npm//@bazel/karma:index.bzl", "karma_web_test_suite")with
load("@npm//@bazel/concatjs:index.bzl", "karma_web_test_suite")finally drop npm dependencies on
@bazel/karmaand depend on@bazel/concatjsinstead