-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release notes for v1.9.0 contain incorrect url for http_archive #1065
Comments
Thanks for catching this. I updated the description to point at the correct URL. |
Thank you! |
The release notes are still wrong. The archive at the updated download link has no "rules_kotlin-1.9.0" prefix to strip so bazel complains. Also
seems to contradict
Why have we switched the repository name from "io_bazel_rules_kotlin" to "rules_kotlin"? |
Argh thanks for pointing that out. The release notes have been updated again and have a PR up for the strip_prefix changes here #1070.
So that we are more in line with what other rules are doing and so that the rules name now matches the Github repository. Ex: bazelbuild/rules_android@ad1727a |
The release notes for release v1.9.0 contain this snippet
but when I actually click on the above link or use it in a rule, I get a 404: https://github.com/buildfoundation/rules_kotlin/releases/download/v1.9.0/rules_kotlin-v1.9.0.tar.gz
is it supposed to reference the repo bazelbuild/rules_kotlin instead? This does work for me: https://github.com/bazelbuild/rules_kotlin/releases/download/v1.9.0/rules_kotlin-v1.9.0.tar.gz
The text was updated successfully, but these errors were encountered: