Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag --incompatible_python_disable_py2 will break rules_jvm_external in Bazel 7.0 #846

Closed
keertk opened this issue Jan 27, 2023 · 1 comment · Fixed by #847
Closed

Flag --incompatible_python_disable_py2 will break rules_jvm_external in Bazel 7.0 #846

keertk opened this issue Jan 27, 2023 · 1 comment · Fixed by #847

Comments

@keertk
Copy link

keertk commented Jan 27, 2023

Incompatible flag --incompatible_python_disable_py2 will be enabled by default in the next major release (Bazel 7.0), thus breaking rules_jvm_external. Please migrate to fix this and unblock the flip of this flag.

The flag is documented here: bazelbuild/bazel#17293.

Please check the following CI builds for build and test results:

Never heard of incompatible flags before? We have documentation that explains everything.
If you have any questions, please file an issue in https://github.com/bazelbuild/continuous-integration.
@keertk keertk mentioned this issue Jan 27, 2023
Closed
@rickeylev
Copy link
Contributor

This appears to be the cause: https://github.com/bazelbuild/rules_jvm_external/blob/master/examples/android_instrumentation_test/.bazelrc#L3

build --host_force_python=PY2 in examples/android_instrumentation_test/.bazelrc

rickeylev added a commit to rickeylev/rules_jvm_external that referenced this issue Jan 27, 2023
@rickeylev
Remove --host_force_python from example bazelrc
513047d 
Bazel is removing support for Python 2

Fixes bazel-contrib#846
@rickeylev rickeylev mentioned this issue Jan 27, 2023
Merged
shs96c pushed a commit that referenced this issue Jan 28, 2023
@rickeylev
Remove --host_force_python from example bazelrc (#847)
263f6f4 
Bazel is removing support for Python 2

Fixes #846
thirtyseven pushed a commit to thirtyseven/rules_jvm_external that referenced this issue Jun 29, 2023
@rickeylev @thirtyseven
Remove --host_force_python from example bazelrc (bazel-contrib#847)
c3f3345 
Bazel is removing support for Python 2

Fixes bazel-contrib#846
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove --host_force_python from example bazelrc rickeylev/rules_jvm_external
2 participants
@rickeylev @keertk