Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vendor dirs not in root of the repo #486

Closed
tomwilkie opened this issue May 27, 2017 · 4 comments
Closed

Support vendor dirs not in root of the repo #486

tomwilkie opened this issue May 27, 2017 · 4 comments

Comments

@tomwilkie
Copy link

Gazelle expects the vendor directory to be in the root of the repo. This isn't always the case. Would it be possible to pass the vendor directory location?

@jayconrod
Copy link
Contributor

Seems like something we should support.

I'm currently wrapping up some improvements for handling build constraints in Gazelle. Once that work is done, I'll be focusing on improving Gazelle's management of dependencies. This will fit into that project.

@pwittrock
Copy link

Any update on this? I need to run carefully crafted sed scripts after running gazelle.

the equivalent of go list -f '{{ join .Deps "\n"}}' | grep might be able to provide this

@jayconrod
Copy link
Contributor

#859 will solve this.

At the moment, Gazelle converts import paths to Bazel deps just by transforming the string without checking whether something is there or not. That prevents us from using vendor directories that aren't at the root of the repository.

#859 is a proposal to index all of the packages in a repository by import path, then choose something appropriate. I'm planning to work on that as soon as we ship support for proto rules (#868). It should be in the major release after the current one we're about to tag, hopefully in a month or so.

@jayconrod
Copy link
Contributor

This should be working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants