Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change build test name from 'need_test' to 'build_only' #3448

Closed
uberzzr opened this issue Feb 7, 2023 · 0 comments · Fixed by #3449
Closed

change build test name from 'need_test' to 'build_only' #3448

uberzzr opened this issue Feb 7, 2023 · 0 comments · Fixed by #3449

Comments

@uberzzr
Copy link
Contributor

uberzzr commented Feb 7, 2023

What version of rules_go are you using?

0.38.0

What version of gazelle are you using?

0.29.0

What version of Bazel are you using?

6.0.0-homebrew

Does this issue reproduce with the latest releases of all the above?

Yes

What operating system and processor architecture are you using?

Mac OS
arm64

Any other potentially useful information about your toolchain?

No

What did you do?

We add build_test target since we cannot run tests in those packages, while the name need_test is confusing. To make it more clearly, I changed the name from need_test to build_only.

What did you expect to see?

bazel test works fine with all the test targets

What did you see instead?

The bazel test works successfully with all the packages that were excluded, except packages with /internal/ or /testdata/ in its path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant