Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github.com/google/go-genproto #1656

Closed
doroginin opened this issue Aug 13, 2018 · 2 comments
Closed

Update github.com/google/go-genproto #1656

doroginin opened this issue Aug 13, 2018 · 2 comments

Comments

@doroginin
Copy link

Please update github.com/google/go-genproto to the latest revision
https://github.com/bazelbuild/rules_go/blob/c73c25f2ead2b6d2cf772878e88a650f07a3de7c/go/private/repositories.bzl#L141

In grpc-ecosystem/grpc-gateway#712 project we need this googleapis/go-genproto@383e8b2 version.

@achew22
Copy link
Member

achew22 commented Aug 13, 2018

Would it also be possible to make a knob to control the version or is it better for us to explicitly list our dependencies?

@jayconrod
Copy link
Contributor

@doroginin I'll update this today. I'll likely do another major release (0.15.0) this week because there's some other stuff I want to ship.

@achew22 It's better to explicitly list dependencies. In cases where you need to override a version, you can write the rule before the call to go_rules_dependencies(). I just wrote up an example of this: Overriding dependencies.

If you're providing a similar macro for grpc-gateway, it may get confusing for users very quickly though. Bazel's working on recursive WORKSPACE evaluation, but it may be some time before that's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants