Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base:Unit_tests are failing with Bazel@HEAD in CI #6172

Closed
sgowroji opened this issue Feb 28, 2024 · 3 comments · Fixed by #6188
Closed

Base:Unit_tests are failing with Bazel@HEAD in CI #6172

sgowroji opened this issue Feb 28, 2024 · 3 comments · Fixed by #6188
Assignees
Labels
awaiting-maintainer Awaiting review from Bazel team on issues product: IntelliJ IntelliJ plugin topic: testing type: bug

Comments

@sgowroji
Copy link
Member

sgowroji commented Feb 28, 2024

CI: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3685#018ded76-5ea3-4372-bcaa-99f8ee002e85

Platform: Ubuntu

Logs:


FAIL: //base:unit_tests (Exit 1) (see /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f177a7553c2b5378efd424b080c7e48f/execroot/_main/bazel-out/k8-fastbuild/testlogs/base/unit_tests/test_attempts/attempt_2.log)
--
  | (02:11:32) [401 / 405] 6 / 10 tests; 4 actions running; last test: //cpp:integration_tests
  | Testing //aswb:normal_integration_tests; 23s remote-cache, linux-sandbox
  | Testing //base:integration_tests; 16s remote-cache, linux-sandbox
  | Testing //java:integration_tests; 15s remote-cache, linux-sandbox
  | Testing //base:unit_tests; 11s remote-cache, linux-sandbox
  | buildkite-agent artifact upload base/unit_tests/test_attempts/attempt_2.log
  | 2024-02-28 02:11:33 INFO   Found 1 files that match "base/unit_tests/test_attempts/attempt_2.log"
  | (02:11:37) FAIL: //base:unit_tests (Exit 1) (see /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f177a7553c2b5378efd424b080c7e48f/execroot/_main/bazel-out/k8-fastbuild/testlogs/base/unit_tests/test.log)
  |  
  | FAILED: //base:unit_tests (Summary)


Culprit:

Steps:

git clone https://github.com/bazelbuild/intellij
git reset 2fd70a88f20d37244656bd3b5f104c9d50e051e7  --hard
export USE_BAZEL_VERSION=8fa62447f76ae586dc39edab8740dd7e5d9fa11e
bazel build --define=ij_product=android-studio-oss-oldest-stable  -- //aswb/... 

CC Greenteam @meteorcloudy

@sgowroji sgowroji added product: Android Studio Android Studio plugin type: bug topic: testing awaiting-maintainer Awaiting review from Bazel team on issues labels Feb 28, 2024
@mai93
Copy link
Collaborator

mai93 commented Feb 28, 2024

@meteorcloudy the test is passing with released Bazel as the version was part of the jar path, so it looked like @@rules_jvm_external~6.0~maven~com_google_guava_guava//jar:jar but with bazel@head it is @@rules_jvm_external~~maven~com_google_guava_guava//jar:jar, is this the new format and we should adjust the test for it?

@sgowroji sgowroji added product: IntelliJ IntelliJ plugin and removed product: Android Studio Android Studio plugin labels Feb 28, 2024
@meteorcloudy
Copy link
Member

meteorcloudy commented Feb 28, 2024

Indeed, this was due to bazelbuild/bazel#21035 which is also backported to 7.1.0. In general, the canonical repo name format is not an API you should depend on if that's possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-maintainer Awaiting review from Bazel team on issues product: IntelliJ IntelliJ plugin topic: testing type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants