Replace INFO with FINE logging in CoverageOutputGenerator
#22257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces unconditional log spam for coverage report actions. If needed, users can configure the loglevel by wrapping the `CoverageOutputGenerator` jar into a `java_binary` with appropriate `jvmopts`.
github-actions
bot
added
the
awaiting-review
iancha1992
added
the
team-Rules-Server
I don't think this is a good way to configure logging levels, although I don't see much of an alternative without adding to Bazel's large collection of flags... |
c-mita
approved these changes
May 7, 2024
c-mita
added
awaiting-PR-merge
|
@c-mita Are you going to create a new release after the merge? |
|
Yes, although I might need to review (or actually formalize) the process first. There's a long standing issue re. provenance (#15459). |
github-actions
bot
removed
the
awaiting-PR-merge
Kila2
pushed a commit
to Kila2/bazel
that referenced
this pull request
May 13, 2024
This reduces unconditional log spam for coverage report actions. If needed, users can configure the loglevel by wrapping the `CoverageOutputGenerator` jar into a `java_binary` with appropriate `jvmopts`. Closes bazelbuild#22257. PiperOrigin-RevId: 631849225 Change-Id: I3c656216b81f6a5920edf46e7ae1b8afe970faef
|
Would it be possible to release a remote_coverage_tools with this fix? The coverage log spam is still making our build logs pretty hard to read. |
|
@c-mita can you take a look? |
|
friendly bump on this |
|
@c-mita any chance this fix could make it into Bazel 8? |
c-mita
added a commit
to c-mita/bazel
that referenced
this pull request
Dec 6, 2024
Built at commit 93e76f2. Relevant changes: * Log level for many messages changed from INFO to FINE (bazelbuild#22257). * IOExceptions are no longer ignored (bazelbuild#21987). * Baseline coverage files are not ignored (bazelbuild#24563). RELNOTES: Baseline coverage files are no longer ignored.
c-mita
added a commit
to c-mita/bazel
that referenced
this pull request
Dec 6, 2024
Built at commit 93e76f2. Relevant changes: * Log level for many messages changed from INFO to FINE (bazelbuild#22257). * IOExceptions are no longer ignored (bazelbuild#21987). * Baseline coverage files are not ignored (bazelbuild#24563). RELNOTES: Baseline coverage files are no longer ignored.
c-mita
added a commit
to c-mita/bazel
that referenced
this pull request
Dec 6, 2024
Built at commit 93e76f2. Relevant changes: * Log level for many messages changed from INFO to FINE (bazelbuild#22257). * IOExceptions are no longer ignored (bazelbuild#21987). * Baseline coverage files are not ignored (bazelbuild#24563). RELNOTES: Baseline coverage files are no longer ignored.
c-mita
added a commit
to c-mita/bazel
that referenced
this pull request
Dec 10, 2024
Built at commit 93e76f2. Relevant changes: * Log level for many messages changed from INFO to FINE (bazelbuild#22257). * IOExceptions are no longer ignored (bazelbuild#21987). * Baseline coverage files are not ignored (bazelbuild#24563). RELNOTES: Baseline coverage files are no longer ignored.
c-mita
added a commit
to c-mita/bazel
that referenced
this pull request
Dec 10, 2024
Built at commit 93e76f2. Relevant changes: * Log level for many messages changed from INFO to FINE (bazelbuild#22257). * IOExceptions are no longer ignored (bazelbuild#21987). * Baseline coverage files are not ignored (bazelbuild#24563). RELNOTES: Baseline coverage files are no longer ignored.
c-mita
added a commit
to c-mita/bazel
that referenced
this pull request
Dec 10, 2024
Built at commit 93e76f2. Relevant changes: * Log level for many messages changed from INFO to FINE (bazelbuild#22257). * IOExceptions are no longer ignored (bazelbuild#21987). * Baseline coverage files are not ignored (bazelbuild#24563). RELNOTES: Baseline coverage files are no longer ignored.
c-mita
added a commit
to c-mita/bazel
that referenced
this pull request
Dec 10, 2024
Built at commit b09335b. Relevant changes: * Log level for many messages changed from INFO to FINE (bazelbuild#22257). * IOExceptions are no longer ignored (bazelbuild#21987). * Baseline coverage files are not ignored (bazelbuild#24563). RELNOTES: Baseline coverage files are no longer ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces unconditional log spam for coverage report actions. If needed, users can configure the loglevel by wrapping the
CoverageOutputGeneratorjar into ajava_binarywith appropriatejvmopts.