Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default visionOS CPU to sim_arm64 #21150

Conversation

BalestraPatrick
Copy link
Member

@BalestraPatrick BalestraPatrick commented Jan 31, 2024

This is a follow-up to #20335. Given the fact that x86_64 isn't supported for visionOS, we should change the default to be sim_arm64 (the simulator version to follow the other CPU defaults we have).

@BalestraPatrick BalestraPatrick force-pushed the change-default-cpu-for-visionos branch from 4f15141 to c8e069a Compare January 31, 2024 12:19
@BalestraPatrick BalestraPatrick changed the title Update default visionOS CPU to arm64 Update default visionOS CPU to sim_arm64 Jan 31, 2024
@BalestraPatrick BalestraPatrick marked this pull request as ready for review January 31, 2024 14:05
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jan 31, 2024
Copy link
Member

@keith keith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops thanks

@iancha1992 iancha1992 added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Jan 31, 2024
@meteorcloudy meteorcloudy added team-Rules-CPP Issues for C++ rules awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Feb 6, 2024
@copybara-service copybara-service bot closed this in 6922aea Feb 7, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Feb 7, 2024
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Feb 7, 2024
@meteorcloudy
Copy link
Member

@bazel-io fork 7.1.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Feb 7, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Feb 7, 2024
This is a follow-up to bazelbuild#20335. Given the fact that x86_64 isn't supported for visionOS, we should change the default to be sim_arm64 (the simulator version to follow the other CPU defaults we have).

Closes bazelbuild#21150.

PiperOrigin-RevId: 604910241
Change-Id: I1f60fd9ee61e74597a667d5e175887e78e668930
github-merge-queue bot pushed a commit that referenced this pull request Feb 7, 2024
This is a follow-up to #20335.
Given the fact that x86_64 isn't supported for visionOS, we should
change the default to be sim_arm64 (the simulator version to follow the
other CPU defaults we have).

Closes #21150.

Commit
6922aea

PiperOrigin-RevId: 604910241
Change-Id: I1f60fd9ee61e74597a667d5e175887e78e668930

Co-authored-by: Patrick Balestra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants