-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default visionOS CPU to sim_arm64 #21150
Closed
BalestraPatrick
wants to merge
1
commit into
bazelbuild:master
from
BalestraPatrick:change-default-cpu-for-visionos
Closed
Update default visionOS CPU to sim_arm64 #21150
BalestraPatrick
wants to merge
1
commit into
bazelbuild:master
from
BalestraPatrick:change-default-cpu-for-visionos
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalestraPatrick
force-pushed
the
change-default-cpu-for-visionos
branch
from
January 31, 2024 12:19
4f15141
to
c8e069a
Compare
BalestraPatrick
changed the title
Update default visionOS CPU to arm64
Update default visionOS CPU to sim_arm64
Jan 31, 2024
github-actions
bot
added
the
awaiting-review
PR is awaiting review from an assigned reviewer
label
Jan 31, 2024
brentleyjones
approved these changes
Jan 31, 2024
keith
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops thanks
iancha1992
added
the
team-ExternalDeps
External dependency handling, remote repositiories, WORKSPACE file.
label
Jan 31, 2024
meteorcloudy
approved these changes
Feb 6, 2024
meteorcloudy
added
team-Rules-CPP
Issues for C++ rules
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
and removed
team-ExternalDeps
External dependency handling, remote repositiories, WORKSPACE file.
awaiting-review
PR is awaiting review from an assigned reviewer
labels
Feb 6, 2024
github-actions
bot
removed
the
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
label
Feb 7, 2024
@bazel-io flag |
bazel-io
added
the
potential release blocker
Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone
label
Feb 7, 2024
@bazel-io fork 7.1.0 |
bazel-io
removed
the
potential release blocker
Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone
label
Feb 7, 2024
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Feb 7, 2024
This is a follow-up to bazelbuild#20335. Given the fact that x86_64 isn't supported for visionOS, we should change the default to be sim_arm64 (the simulator version to follow the other CPU defaults we have). Closes bazelbuild#21150. PiperOrigin-RevId: 604910241 Change-Id: I1f60fd9ee61e74597a667d5e175887e78e668930
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
This is a follow-up to #20335. Given the fact that x86_64 isn't supported for visionOS, we should change the default to be sim_arm64 (the simulator version to follow the other CPU defaults we have). Closes #21150. Commit 6922aea PiperOrigin-RevId: 604910241 Change-Id: I1f60fd9ee61e74597a667d5e175887e78e668930 Co-authored-by: Patrick Balestra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #20335. Given the fact that x86_64 isn't supported for visionOS, we should change the default to be sim_arm64 (the simulator version to follow the other CPU defaults we have).