-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash on bazel mod
error containing %
#20627
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`bazel mod show_extension @foo//:extensions.bzl%go_sdk`resulted in the crash: ``` java.util.IllegalFormatConversionException: g != java.lang.String ``` Also makes an error more readable by swapping a `:`.
@bazel-io flag |
github-actions
bot
added
the
awaiting-review
PR is awaiting review from an assigned reviewer
label
Dec 20, 2023
bazel-io
added
the
potential release blocker
Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone
label
Dec 20, 2023
Wyverald
approved these changes
Dec 20, 2023
Wyverald
added
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
and removed
awaiting-review
PR is awaiting review from an assigned reviewer
labels
Dec 20, 2023
@bazel-io fork 7.1.0 |
bazel-io
removed
the
potential release blocker
Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone
label
Dec 20, 2023
iancha1992
added
the
team-ExternalDeps
External dependency handling, remote repositiories, WORKSPACE file.
label
Dec 20, 2023
github-actions
bot
removed
the
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
label
Dec 21, 2023
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Dec 21, 2023
`bazel mod show_extension @foo//:extensions.bzl%go_sdk`resulted in the crash: ``` java.util.IllegalFormatConversionException: g != java.lang.String ``` Also makes an error more readable by swapping a `:`. Closes bazelbuild#20627. PiperOrigin-RevId: 592942775 Change-Id: Ida5c234413c1647f81d3702bb9deeedcdd93df12
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
`bazel mod show_extension @foo//:extensions.bzl%go_sdk`resulted in the crash: ``` java.util.IllegalFormatConversionException: g != java.lang.String ``` Also makes an error more readable by swapping a `:`. Closes #20627. Commit 6e6e6f8 PiperOrigin-RevId: 592942775 Change-Id: Ida5c234413c1647f81d3702bb9deeedcdd93df12 Co-authored-by: Fabian Meumertzheim <[email protected]> Co-authored-by: Xùdōng Yáng <[email protected]> Co-authored-by: Ian (Hee) Cha <[email protected]>
The changes in this PR have been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bazel mod show_extension @foo//:extensions.bzl%go_sdk
resulted in the crash:Also makes an error more readable by swapping a
:
.