Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on bazel mod error containing % #20627

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Dec 20, 2023

bazel mod show_extension @foo//:extensions.bzl%go_sdkresulted in the crash:

java.util.IllegalFormatConversionException: g != java.lang.String

Also makes an error more readable by swapping a :.

`bazel mod show_extension @foo//:extensions.bzl%go_sdk`resulted in the
crash:
```
java.util.IllegalFormatConversionException: g != java.lang.String
```

Also makes an error more readable by swapping a `:`.
@fmeum fmeum requested a review from Wyverald December 20, 2023 22:11
@fmeum
Copy link
Collaborator Author

fmeum commented Dec 20, 2023

@bazel-io flag

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Dec 20, 2023
@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 20, 2023
@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Dec 20, 2023
@iancha1992
Copy link
Member

@bazel-io fork 7.1.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 20, 2023
@iancha1992 iancha1992 added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Dec 20, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Dec 21, 2023
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Dec 21, 2023
`bazel mod show_extension @foo//:extensions.bzl%go_sdk`resulted in the crash:
```
java.util.IllegalFormatConversionException: g != java.lang.String
```

Also makes an error more readable by swapping a `:`.

Closes bazelbuild#20627.

PiperOrigin-RevId: 592942775
Change-Id: Ida5c234413c1647f81d3702bb9deeedcdd93df12
@fmeum fmeum deleted the improve-bazel-mod-errors branch December 22, 2023 08:15
github-merge-queue bot pushed a commit that referenced this pull request Jan 9, 2024
`bazel mod show_extension @foo//:extensions.bzl%go_sdk`resulted in the
crash:
```
java.util.IllegalFormatConversionException: g != java.lang.String
```

Also makes an error more readable by swapping a `:`.

Closes #20627.

Commit
6e6e6f8

PiperOrigin-RevId: 592942775
Change-Id: Ida5c234413c1647f81d3702bb9deeedcdd93df12

Co-authored-by: Fabian Meumertzheim <[email protected]>
Co-authored-by: Xùdōng Yáng <[email protected]>
Co-authored-by: Ian (Hee) Cha <[email protected]>
@iancha1992
Copy link
Member

The changes in this PR have been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants