Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.4.0] Fix unconditional Skyframe invalidation with --lockfile_mode=update #19848

Merged
merged 1 commit into from
Oct 17, 2023
Merged

[6.4.0] Fix unconditional Skyframe invalidation with --lockfile_mode=update #19848

merged 1 commit into from
Oct 17, 2023

Commits on Oct 17, 2023

  1. [6.4.0] Fix unconditional Skyframe invalidation with --lockfile_mode=… 

    …update

Ensure that `BazelLockFileModule` only updates `MODULE.bazel.lock` if the content of the file needs to change. Every such update changes the file's metadata, which results in Skyframe invalidation of, in particular, all configurations. This broke `bazel config`, which uses `MemoizingEvaluator#getDoneValues()` to directly observe Skyframe state.

Compared to the original commit bazelbuild@78db9ae, this cherry-pick does not include the change to `bazel config` as it may not be backwards compatible (changes the exit code in certain situations).

Fixes bazelbuild#19823

Closes bazelbuild#19842.

PiperOrigin-RevId: 574133346
Change-Id: I5886c91fc6b7b938a7dee59ea75aa7b8afb5b161

Fixes bazelbuild#19843
    @fmeum
    fmeum authored Oct 17, 2023
    Configuration menu
    Copy the full SHA
    c735d8a View commit details
    Browse the repository at this point in the history