Silence swiftmodule timestamp warnings #13165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of bazelbuild#13091 dsymtuil started producing these warnings: ``` warning: Timestamp mismatch for bazel-out/ios-x86_64-min11.0-applebin_ios-ios_x86_64-fastbuild-ST-7786d55448f4/bin/Modules/DependencyInjection/DependencyInjection.swiftmodule: 2021-03-05 13:54:33.542331246 and 1969-12-31 16:00:00.000000000 ``` In general we're happily ignoring this to get hermetic outputs instead (it's being compared against the file modification timestamp) This change disables this warning. It appears this feature has been around for at least 3 years swiftlang/llvm-project@2dd9848 so we should be good for all the versions of Xcode we support. Relevant logic: https://github.com/apple/llvm-project/blob/902bb11a46eb82e81d7e8b34450481e143a208b2/llvm/tools/dsymutil/DwarfLinkerForBinary.cpp#L407-L421
thii
approved these changes
Mar 6, 2021
|
@oquenchil can you review? |
brentleyjones
approved these changes
Mar 22, 2021
|
@oquenchil thanks, can you help land this? |
philwo
pushed a commit
that referenced
this pull request
Apr 20, 2021
As part of #13091 dsymtuil started producing these warnings: ``` warning: Timestamp mismatch for bazel-out/ios-x86_64-min11.0-applebin_ios-ios_x86_64-fastbuild-ST-7786d55448f4/bin/Modules/DependencyInjection/DependencyInjection.swiftmodule: 2021-03-05 13:54:33.542331246 and 1969-12-31 16:00:00.000000000 ``` In general we're happily ignoring this to get hermetic outputs instead (it's being compared against the file modification timestamp) This change disables this warning. It appears this feature has been around for at least 3 years swiftlang/llvm-project@2dd9848 so we should be good for all the versions of Xcode we support. Relevant logic: https://github.com/apple/llvm-project/blob/902bb11a46eb82e81d7e8b34450481e143a208b2/llvm/tools/dsymutil/DwarfLinkerForBinary.cpp#L407-L421 Closes #13165. PiperOrigin-RevId: 366215825
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #13091 dsymtuil started producing these warnings:
In general we're happily ignoring this to get hermetic outputs instead (it's being compared against the file modification timestamp)
This change disables this warning.
It appears this feature has been around for at least 3 years swiftlang/llvm-project@2dd9848 so we should be good for all the versions of Xcode we support.
Relevant logic: https://github.com/apple/llvm-project/blob/902bb11a46eb82e81d7e8b34450481e143a208b2/llvm/tools/dsymutil/DwarfLinkerForBinary.cpp#L407-L421