-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move --repo_env to common options #13003
Conversation
--repo_env should be a common option, it causes issues with repository syncing. Upstream PR: bazelbuild#13003 --- Automatic squash commit from https://github.sc-corp.net/Snapchat/bazel/pull/93 Cooled by chancila
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
9a0e0c2
to
cdd0da5
Compare
@googlebot I fixed it. |
not really sure why the rbe action fails...
|
Thank you @chancila! I'm merging this now. |
Move --repo_env into common options and inject the value through CommandEnvironment since CommonCommandOptions cannot be accessed in SkyframeExecutor directly due to a circular dependency in the build.
Addresses #12689