Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Java tools v11.1 #12804

Closed
wants to merge 2 commits into from
Closed

Release Java tools v11.1 #12804

wants to merge 2 commits into from

Conversation

comius
Copy link
Contributor

@comius comius commented Jan 11, 2021 •
edited
Loading

Changes:

8cc0e261a3 cushon Include <limits>
960b7a99af Googler Adds an api-android target to the sharding API.
7749cf7579 Googler Use getRunfilesPath when constructing runfiles input manifest maps.
1489f0f4ca Timothy Klim Support Scala3 .tasty files
d113d74541 Liam Miller-Cushon Update turbine
41b3ab66b7 larsrc Create TestUtils methods to generate unique temp dirs, deprecate the current ones that are decidedly non-unique.

Fixes #12605, bazelbuild/java_tools#41

@google-cla google-cla bot added the cla: yes label Jan 11, 2021
@comius comius mentioned this pull request Jan 11, 2021
Closed
@comius comius requested review from meteorcloudy and philwo January 11, 2021 16:13
@comius comius marked this pull request as ready for review January 11, 2021 16:13
aiuto
aiuto reviewed Jan 12, 2021
View reviewed changes
Copy link
Contributor

@aiuto aiuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at #12810
If we go straight to that, this could be much easier. You would only have to update the urls and sha in one file.

meteorcloudy
meteorcloudy approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good. It's better to refactor as Tony suggested, but feel free to merge if it's urgent.

@comius
Copy link
Contributor Author

comius commented Jan 12, 2021

Please take a look at #12810
If we go straight to that, this could be much easier. You would only have to update the urls and sha in one file.

Sure it looks better after refactoring. This is not that critical, I can wait with this PR and rebase once @aiuto is done.

@comius comius force-pushed the java-tools_release_11.1 branch from 1090242 to a47edc7 Compare January 13, 2021 10:48
@comius comius changed the title Java tools release 11.1 Release Java tools v11.1 Jan 13, 2021
@bazel-io bazel-io closed this in 788c71f Jan 13, 2021
benjaminp
benjaminp reviewed Jan 13, 2021
View reviewed changes
distdir_deps.bzl
@@ -227,10 +227,10 @@ DIST_DEPS = {
"remote_java_tools_linux": {
"aliases": ["remote_java_tools_test_linux", "remote_java_tools_linux_for_testing"],
"archive": "java_tools_linux-v11.0.zip",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these lines need to be updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They sure do. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah.. sorry for missing these!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes here #12824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminp benjaminp benjaminp left review comments

@aiuto aiuto aiuto left review comments

@meteorcloudy meteorcloudy meteorcloudy approved these changes

@philwo philwo Awaiting requested review from philwo

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

java_plugin header compilation failure
4 participants
@comius @benjaminp @aiuto @meteorcloudy