Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update remote java_tools to javac11 version v10.1-rc1 #12302

Closed
wants to merge 3 commits into from
Closed

Update remote java_tools to javac11 version v10.1-rc1 #12302

wants to merge 3 commits into from

Conversation

comius
Copy link
Contributor

@comius comius commented Oct 19, 2020 •
edited
Loading

@comius comius self-assigned this Oct 19, 2020
@google-cla google-cla bot added the cla: yes label Oct 19, 2020
@comius comius mentioned this pull request Oct 19, 2020
Closed
@comius comius marked this pull request as ready for review October 19, 2020 16:31
@katre
Copy link
Member

katre commented Oct 19, 2020

I added the verify_workspace test, it checks that all URLs in the WORKSPACE are valid. Are these URLs populated as part of this pipeline? If so, we can disable the test.

@comius
Copy link
Contributor Author

comius commented Oct 19, 2020 via email

@comius
Copy link
Contributor Author

comius commented Oct 19, 2020

Done, tests passing.

@bazel-io bazel-io closed this in ffd088f Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katre katre katre approved these changes

@larsrc-google larsrc-google Awaiting requested review from larsrc-google

@meteorcloudy meteorcloudy Awaiting requested review from meteorcloudy

Assignees

@comius comius

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release: java_tools_javac11-v10.1 (with Java 15 toolchain support)
2 participants
@comius @katre