Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support constraint_value directly in select() #12071

Closed

Commits on Sep 9, 2020

  1. Support constraint_value directly in select().

    No more need for a redundant config_setting. See bazelbuild#8583
    for an example.
    
    This was a bit subtle. constraint_value can't directly
    export a ConfigMatchingProvider because it needs to know the
    platform to determine if it's a match. But platforms are
    built out of constraint_values, so the platform isn't available
    yet. So the parent target with the select() provides this detail.
    
    Also beautifies "invalid select() key" errors in support of bazelbuild#11984.
    
    Fixes bazelbuild#8583.
    
    RELNOTES[NEW]: select() directly supports constraint_value (no need for an intermediate config_setting).
    
    PiperOrigin-RevId: 327885099
    Change-Id: Ifbdfa275ff83f0cb30207a5bd77aca317599fc21
    gregestren committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    54d670d View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2020

  1. Review feedback updates

    gregestren committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    aff487a View commit details
    Browse the repository at this point in the history