Android desugar build broken due to errorprone-detected error

[philwo]

[node=linux-x86_64] ERROR: /home/ci/.cache/bazel/_bazel_ci/568b70756cfa0015d0bb31dbcf941213/bazel-sandbox/1719750086946967760/execroot/io_bazel/_tmp/2a109a4137b457914dd3a6d3268626c4/bazelbootstrap.W9dIJB5M/src/tools/android/java/com/google/devtools/build/android/desugar/BUILD:24:1: Building src/tools/android/java/com/google/devtools/build/android/desugar/libdesugar.jar (30 source files) and running annotation processors (OptionProcessor, AutoAnnotationProcessor, AutoValueProcessor) failed (Exit 1): java failed: error executing command 
[node=linux-x86_64]   (cd /home/ci/.cache/bazel/_bazel_ci/568b70756cfa0015d0bb31dbcf941213/bazel-sandbox/1719750086946967760/execroot/io_bazel/tmp/bazel_wDThJ3V7/out/execroot/io_bazel && \
[node=linux-x86_64]   exec env - \
[node=linux-x86_64]     LC_CTYPE=en_US.UTF-8 \
[node=linux-x86_64]   external/local_jdk/bin/java -XX:+TieredCompilation '-XX:TieredStopAtLevel=1' -Xbootclasspath/p:third_party/java/jdk/langtools/javac-9-dev-r4023-3.jar -jar bazel-out/host/bin/src/java_tools/buildjar/java/com/google/devtools/build/buildjar/bootstrap_deploy.jar @bazel-out/k8-opt/bin/src/tools/android/java/com/google/devtools/build/android/desugar/libdesugar.jar-2.params)
[node=linux-x86_64] src/tools/android/java/com/google/devtools/build/android/desugar/LambdaClassMaker.java:85: error: [StreamResourceLeak] Streams that encapsulate a closeable resource should be closed using try-with-resources
[node=linux-x86_64]         Files.list(rootPathPrefix.getParent())
[node=linux-x86_64]                   ^
[node=linux-x86_64]     (see http://errorprone.info/bugpattern/StreamResourceLeak)
[node=linux-x86_64]   Did you mean 'try (Stream<Path> paths ;'?
[node=linux-x86_64] Target //src:bazel failed to build

[jin]

Which run is this from?

The suggested errorprone fix has been merged: https://source.bazel.build/bazel/+/dd6f8298529f05372d9c0c31eabf19f69d38b22e:src/tools/android/java/com/google/devtools/build/android/desugar/LambdaClassMaker.java;h=;l=84

[philwo]

I noticed it during a recent bazel-tests run. Sorry for not linking the log!

Good that the fix is in :) Let’s close this then.

[philwo]

Oh wait, the link goes to a commit from December 16, suggesting that the fix might not have worked maybe? I’ll reopen for now.

[jin]

I can repro this locally at HEAD. Looking.

$ bazel build //src:bazel
$ cp bazel-bin/src/bazel .
$ ./bazel build //src:bazel
INFO: Analysed target //src:bazel (1 packages loaded).
INFO: Found 1 target...
ERROR: /usr/local/google/home/jingwen/bazels/bazel_github/src/tools/android/java/com/google/devtools/build/android/desugar/BUILD:24:1: Building src/tools/android/java/com/google/devtools/build/android/desugar/libdesugar.jar (30 source files) and running annotation processors (OptionProcessor, AutoAnnotationProcessor, AutoValueProcessor) failed (Exit 1)
src/tools/android/java/com/google/devtools/build/android/desugar/LambdaClassMaker.java:85: error: [StreamResourceLeak] Streams that encapsulate a closeable resource should be closed using try-with-resources
        Files.list(rootPathPrefix.getParent())
                  ^
    (see http://errorprone.info/bugpattern/StreamResourceLeak)
  Did you mean 'try (Stream<Path> paths ;'?
Target //src:bazel failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 2.228s, Critical Path: 1.19s
FAILED: Build did NOT complete successfully

[cushon]

Sorry, I sent a fix: https://bazel-review.googlesource.com/c/bazel/+/31292

[jin]

Almost sent out the same fix :-) Will import. Thanks @cushon