-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition to exec configuration for bazel test --run_under=... --platforms=...
#22624
Comments
It seems like the right answer here is that, for the command
Is that a reasonable summary? |
I suspect that |
Yes, that summary sounds right to me. |
It turns out that the |
What happens if Should that change the whole test to run on a Mac execution platform? Stated differently, should exec platform resolution be based on |
I'm not sure how this should interact with exec platform resolution: I spend all my time in the simple world where the exec and host platforms are one and the same! If my host platform is Linux and the |
@tpudlik for I can also see scenarios where |
Closed this specific issue, which is I looked into (but didn't fix) doing the same for bazel/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java Line 1924 in b03e4c5
SkyframeExecutor for transitions. We might be able to copy bazel/src/test/java/com/google/devtools/build/lib/analysis/util/ConfigurationTestCase.java Line 272 in b03e4c5
or even add some implicit exec dependency on top-level targets just to get access to the exec configuration. |
Yes, Bazel does expect that
If you want |
Description of the bug:
bazel test --run_under=:test_runner --platforms=:device
is a natural way to run on-device tests with Bazel: you point--run_under
to your test runner (which flashes tests to the hardware), and--platforms
to the target device platform.But it's awkward in practice because the target that
--run_under
points to is built for the target platform, even though it will execute on the exec platform. So you need to wrap your runner into aplatform_data
:@katre @gregestren
Which category does this issue belong to?
Configurability
What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
No response
Which operating system are you running Bazel on?
No response
What is the output of
bazel info release
?No response
If
bazel info release
returnsdevelopment version
or(@non-git)
, tell us how you built Bazel.No response
What's the output of
git remote get-url origin; git rev-parse HEAD
?No response
Is this a regression? If yes, please try to identify the Bazel commit where the bug was introduced.
No.
Have you found anything relevant by searching the web?
This is similar to the case of
bazel run --run_under --platforms
, discussed here.Any other information, logs, or outputs that you want to share?
No response
The text was updated successfully, but these errors were encountered: