Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.0.1] Avoid emitting canonical labels into generated repos #20825

Closed
bazel-io opened this issue Jan 9, 2024 · 3 comments
Closed

[7.0.1] Avoid emitting canonical labels into generated repos #20825

bazel-io opened this issue Jan 9, 2024 · 3 comments
Milestone
7.0.1 release blo...

Comments

@bazel-io
Copy link
Member

bazel-io commented Jan 9, 2024

Forked from #20810
@bazel-io bazel-io added this to the 7.0.1 release blockers milestone Jan 9, 2024
@bazel-io
Copy link
Member Author

bazel-io commented Jan 9, 2024

Cherry-pick was attempted, but there may be merge conflict(s). Please resolve manually.
cc: @bazelbuild/triage

@meteorcloudy
Copy link
Member

/cc @fmeum

fmeum added a commit to fmeum/bazel that referenced this issue Jan 10, 2024
@fmeum
[7.0.1] Avoid emitting canonical labels into generated repos
7a7acb8 
As long as bazelbuild#20722 isn't resolved, the canonical name for the given apparent name can change without the repo rule being refetched.

Closes bazelbuild#20810.

PiperOrigin-RevId: 597048244
Change-Id: I225424cc32e572b26c6d6e76e2c09c4d2e6a4ba6

Closes bazelbuild#20825
@fmeum fmeum mentioned this issue Jan 10, 2024
Merged
@fmeum
Copy link
Collaborator

fmeum commented Jan 10, 2024

@meteorcloudy I submitted #20840.

fmeum added a commit to fmeum/bazel that referenced this issue Jan 10, 2024
@fmeum
[7.0.1] Avoid emitting canonical labels into generated repos
950d310 
As long as bazelbuild#20722 isn't resolved, the canonical name for the given apparent name can change without the repo rule being refetched.

Closes bazelbuild#20810.

PiperOrigin-RevId: 597048244
Change-Id: I225424cc32e572b26c6d6e76e2c09c4d2e6a4ba6

Closes bazelbuild#20825
iancha1992 pushed a commit that referenced this issue Jan 10, 2024
@fmeum
[7.0.1] Avoid emitting canonical labels into generated repos (#20840)
ce993c4 
As long as #20722 isn't resolved, the canonical name for the given
apparent name can change without the repo rule being refetched.

Closes #20810.

PiperOrigin-RevId: 597048244
Change-Id: I225424cc32e572b26c6d6e76e2c09c4d2e6a4ba6

Closes #20825
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.1 release blockers
Development

No branches or pull requests
4 participants
@Wyverald @meteorcloudy @fmeum @bazel-io