Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.1.0] linker_param_file only added to command line if it starts with "@" #20761

Closed
bazel-io opened this issue Jan 5, 2024 · 4 comments
Closed

[7.1.0] linker_param_file only added to command line if it starts with "@" #20761

bazel-io opened this issue Jan 5, 2024 · 4 comments
Milestone
7.1.0 release blo...

Comments

@bazel-io
Copy link
Member

bazel-io commented Jan 5, 2024

Forked from #18074
@bazel-io bazel-io added this to the 7.1.0 release blockers milestone Jan 5, 2024
@bazel-io
Copy link
Member Author

bazel-io commented Jan 5, 2024

Cherry-pick was attempted, but there may be merge conflict(s). Please resolve manually.
cc: @bazelbuild/triage

@iancha1992
Copy link
Member

@comius it looks like there are some conflicts we cannot resolve on our own. Can you please take a look?

cc: @bazelbuild/triage

@meteorcloudy
Copy link
Member

ping @comius

@comius comius mentioned this issue Feb 7, 2024
Merged
@iancha1992
Copy link
Member

iancha1992 commented Feb 7, 2024 •
edited
Loading

Cherry-picked in #21235 by @comius

github-merge-queue bot pushed a commit that referenced this issue Feb 8, 2024
@comius
[7.1.0] Cherry-pick: linker_param_file only added to command line if …
90d9909 
…it starts with "@" (#21235)

Cherry-picks of:
c92ecbf Replace calls to getRawLinkArgv with calls to arguments
3490df2 Merge extractArgumentsForStaticLinkParamFile and
extractArgumentsForDynamicLinkParamFile
b5cfea5 Refactor splitting of LinkerCommandLine

Fixes: #20761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.1.0 release blockers
Development

No branches or pull requests
3 participants
@meteorcloudy @bazel-io @iancha1992