Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.4.0] cquery's config function doesn't work with Bzlmod #19843

Closed
bazel-io opened this issue Oct 17, 2023 · 3 comments
Closed

[6.4.0] cquery's config function doesn't work with Bzlmod #19843

bazel-io opened this issue Oct 17, 2023 · 3 comments
Milestone
6.4.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #19823
@bazel-io bazel-io added this to the 6.4.0 release blockers milestone Oct 17, 2023
@bazel-io
Copy link
Member Author

Cherry-pick was attempted, but there may be merge conflict(s). Please resolve manually.
cc: @bazelbuild/triage

@meteorcloudy
Copy link
Member

/cc @fmeum We'll need to remove the lockfile hack in the shell test.

fmeum added a commit to fmeum/bazel that referenced this issue Oct 17, 2023
@fmeum
[6.4.0] Fix unconditional Skyframe invalidation with --lockfile_mode=…
c735d8a 
…update

Ensure that `BazelLockFileModule` only updates `MODULE.bazel.lock` if the content of the file needs to change. Every such update changes the file's metadata, which results in Skyframe invalidation of, in particular, all configurations. This broke `bazel config`, which uses `MemoizingEvaluator#getDoneValues()` to directly observe Skyframe state.

Compared to the original commit bazelbuild@78db9ae, this cherry-pick does not include the change to `bazel config` as it may not be backwards compatible (changes the exit code in certain situations).

Fixes bazelbuild#19823

Closes bazelbuild#19842.

PiperOrigin-RevId: 574133346
Change-Id: I5886c91fc6b7b938a7dee59ea75aa7b8afb5b161

Fixes bazelbuild#19843
@fmeum fmeum mentioned this issue Oct 17, 2023
Merged
iancha1992 pushed a commit that referenced this issue Oct 17, 2023
@fmeum
[6.4.0] Fix unconditional Skyframe invalidation with --lockfile_mode=… (
48892ae 
#19848)

…update

Ensure that `BazelLockFileModule` only updates `MODULE.bazel.lock` if
the content of the file needs to change. Every such update changes the
file's metadata, which results in Skyframe invalidation of, in
particular, all configurations. This broke `bazel config`, which uses
`MemoizingEvaluator#getDoneValues()` to directly observe Skyframe state.

Compared to the original commit
78db9ae,
this cherry-pick does not include the change to `bazel config` as it may
not be backwards compatible (changes the exit code in certain
situations).

Fixes #19823

Closes #19842.

PiperOrigin-RevId: 574133346
Change-Id: I5886c91fc6b7b938a7dee59ea75aa7b8afb5b161

Fixes #19843
@iancha1992
Copy link
Member

Cherry-picked in #19848 by @fmeum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.4.0 release blockers
Development

No branches or pull requests
3 participants
@meteorcloudy @bazel-io @iancha1992