Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Android shell tests don't build on Apple Silicon CI workers #16521

Closed
fweikert opened this issue Oct 20, 2022 · 3 comments
Closed

Some Android shell tests don't build on Apple Silicon CI workers #16521

fweikert opened this issue Oct 20, 2022 · 3 comments
Assignees
Labels
m1-ci macos-infra-update P1 I'll work on this now. (Assignee required) team-Android Issues for Android team type: bug

Comments

@fweikert
Copy link
Member

fweikert commented Oct 20, 2022

Description of the bug:

I'm working on adding M1 Mac Studio Ultra machines to our CI worker pool. These machines come with Android build-tools 31.0.0 since the older versions running on CI so far (28.0.2 and 30.0.3) cannot be installed on M1 machines.

Unfortunately this means that some of our Android shell tests started failing. This is due to 31.0.0 replacing dx with d8, but some of our tests still rely on dx.jar:

ERROR: /Users/buildkite/builds/bk-macstudio-1/bazel/google-bazel-presubmit/src/test/shell/bazel/android/BUILD:86:16: Middleman _middlemen/src_Stest_Sshell_Sbazel_Sandroid_Sproguard_Uintegration_Utest-runfiles failed: missing input file 'external/androidsdk/build-tools/31.0.0/lib/dx.jar', owner: '@androidsdk//:build-tools/31.0.0/lib/dx.jar'

(https://buildkite.com/bazel/google-bazel-presubmit/builds/60433#0183f649-476f-4153-bc42-673a96e5065a)

I've added some "magic" flags suggested by @ahumesky, but without any success:

--define=android_incremental_dexing_tool=d8_dexbuilder
--define=android_dexmerger_tool=d8_dexmerger
--nouse_workers_with_dexbuilder

So far this bug affects at least three tests:

  • //src/test/shell/bazel/android:android_integration_test
  • //src/test/shell/bazel/android:desugarer_integration_test
  • //src/test/shell/bazel/android:proguard_integration_test

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

No response

Which operating system are you running Bazel on?

Bazel CI on MacOS monterey 12.6

What is the output of bazel info release?

5.3.2

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@fweikert fweikert added the m1-ci label Oct 21, 2022
@ahumesky ahumesky added P1 I'll work on this now. (Assignee required) and removed untriaged labels Oct 25, 2022
@meteorcloudy
Copy link
Member

Please re-enable the failing tests in Bazel's presubmit.yml and postsubmit.yml file after fixing them!

@meteorcloudy
Copy link
Member

Looks like https://issuetracker.google.com/issues/190734097#comment23 is related.

@ahumesky @ted-xie Do you have any plan to fix this? I'm trying to make sure all Bazel integration tests work on arm64 mac so that we can deprecate Intel Mac machines in future.

@meteorcloudy
Copy link
Member

We are not going to fix those tests since we are moving out android rules from Bazel

@meteorcloudy meteorcloudy closed this as not planned Won't fix, can't repro, duplicate, stale Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
m1-ci macos-infra-update P1 I'll work on this now. (Assignee required) team-Android Issues for Android team type: bug
Projects
None yet
Development

No branches or pull requests

4 participants