Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Cherry pick cc_shared_library commits #15713

Closed
learning-to-play opened this issue Jun 21, 2022 · 4 comments
Closed

[5.3] Cherry pick cc_shared_library commits #15713

learning-to-play opened this issue Jun 21, 2022 · 4 comments
Assignees

Comments

@learning-to-play
Copy link

Description of the bug:

Can you cherry pick the commits that fix bugs or add features to cc_shared_library including:

  • Adding regular library in interface_library group of cc_shared_library
  • Remove unnecessary files from the runfiles of cc_shared_library

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

No response

Which operating system are you running Bazel on?

Linux, macOS, Windows

What is the output of bazel info release?

No response

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@meteorcloudy
Copy link
Member

I guess the commits we need to cherry-pick are d7a9a37 and 26d882f.

/cc @oquenchil Can you please confirm this?

@oquenchil
Copy link
Contributor

Yes, I can confirm!

@learning-to-play
Copy link
Author

It seems cc_shared_library is using the actual library rather than the interface library to link on Windows. Is this something that needs to be fixed on the Bazel size? If so, can you cherry pick that one, too?

@ckolli5
Copy link

ckolli5 commented Jul 2, 2022

Closed #15754

@ckolli5 ckolli5 closed this as completed Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants