Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

java_stub_template hard-codes local_jdk #11179

Closed
katre opened this issue Apr 21, 2020 · 0 comments
Closed

java_stub_template hard-codes local_jdk #11179

katre opened this issue Apr 21, 2020 · 0 comments
Assignees
@katre
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Rules-Java Issues for Java rules type: bug

Comments

@katre
Copy link
Member

katre commented Apr 21, 2020

In java_stub_template.txt, when executing the actual java binary, if the classpath is too long a fake JAR is created and executed. However, the stub currently harcodes the use of local_jdk.

An upcoming change to split the build-base target greatly inflates the number of targets, and thus classpath entries, which triggers this issue in several Bazel builds and tests.
@katre katre added type: bug P2 We'll consider working on this in future. (Assignee optional) team-Rules-Java Issues for Java rules labels Apr 21, 2020
@katre katre self-assigned this Apr 21, 2020
@katre katre mentioned this issue Apr 21, 2020
Closed
bazel-io pushed a commit that referenced this issue Apr 22, 2020
@katre @copybara-github
Temporary fix for gen_command-line_reference until #11179 is fixed an…
2a99526 
…d released.

PiperOrigin-RevId: 307798565
@ittaiz ittaiz mentioned this issue Jul 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katre katre

Labels
P2 We'll consider working on this in future. (Assignee optional) team-Rules-Java Issues for Java rules type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't hardcode a specific JDK in the java stub template. katre/bazel
1 participant
@katre