Fix codesmell in Crosstool.java.

PiperOrigin-RevId: 399688994
bazelbuild · Sep 29, 2021 · 08f3e93 · 08f3e93
1 parent 4d4ab50
commit 08f3e93
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/test/java/com/google/devtools/build/lib/packages/util/Crosstool.java b/src/test/java/com/google/devtools/build/lib/packages/util/Crosstool.java
@@ -28,6 +28,7 @@
 import java.util.Collection;
 import java.util.HashSet;
 import java.util.LinkedHashSet;
+import java.util.List;
 import java.util.Set;
 
 /**
@@ -379,14 +380,15 @@ public String getCcToolchainConfigRule() {
   private final String crosstoolTop;
   private final Label crosstoolTopLabel;
   private String ccToolchainConfigFileContents;
-  private ImmutableList<String> archs;
+  private final List<String> archs;
   private boolean supportsHeaderParsing;
   private ImmutableList<CcToolchainConfig> ccToolchainConfigList = ImmutableList.of();
 
   Crosstool(MockToolsConfig config, String crosstoolTop, Label crosstoolTopLabel) {
     this.config = config;
     this.crosstoolTop = crosstoolTop;
     this.crosstoolTopLabel = crosstoolTopLabel;
+    this.archs = new ArrayList<>();
   }
 
   public Crosstool setCcToolchainFile(String ccToolchainConfigFileContents) {
@@ -395,7 +397,8 @@ public Crosstool setCcToolchainFile(String ccToolchainConfigFileContents) {
   }
 
   public Crosstool setSupportedArchs(ImmutableList<String> archs) {
-    this.archs = archs;
+    this.archs.clear();
+    this.archs.addAll(archs);
     return this;
   }