Skip to content

Commit

Permalink
Improve diagnostic for PrepareDepsOfTargetsUnderDirectoryFunctionTest
Browse files Browse the repository at this point in the history
We've been hitting a (flaky?) bug in CI that we haven't been able to reproduce locally yet. The failure is here, so this assertion change should help us see what the actual error message is.

PiperOrigin-RevId: 355062974
  • Loading branch information
brandjon authored and copybara-github committed Feb 2, 2021
1 parent f3c37db commit 042146f
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
package com.google.devtools.build.lib.skyframe;

import static com.google.common.truth.Truth.assertThat;
import static com.google.devtools.build.skyframe.EvaluationResultSubjectFactory.assertThatEvaluationResult;
import static com.google.devtools.build.skyframe.WalkableGraphUtils.exists;

import com.google.common.base.Preconditions;
Expand Down Expand Up @@ -82,7 +83,7 @@ private EvaluationResult<?> getEvaluationResult(SkyKey... keys) throws Interrupt
.build();
EvaluationResult<PrepareDepsOfTargetsUnderDirectoryValue> evaluationResult =
skyframeExecutor.getDriver().evaluate(ImmutableList.copyOf(keys), evaluationContext);
Preconditions.checkState(!evaluationResult.hasError());
assertThatEvaluationResult(evaluationResult).hasNoError();
return evaluationResult;
}

Expand Down

0 comments on commit 042146f

Please sign in to comment.