-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gazelle plugin just deleting srcs
from some libraries
#454
Comments
Interesting! Were the old values generated with the gazelle plugin? |
No, these were hand-written rules originally. I'm trying to enable gazelle support for them so we can stop hand-writing so much :-) |
It appears to be because these are files which define a rule which is itself a test rule, thus the files end in "_test.bzl" and are (erroneously) ignored due to: bazel-skylib/gazelle/bzl/gazelle.go Line 51 in 288731e
|
Very interesting find! I believe the logic behind that is that it is possible to make I'm curious what your thoughts on this are? Would you be amenable to naming the file |
yeah, it's just a lot of work to update all of the references |
You don't want an excuse to fire up rosie 😉 ? |
I hit this case too, we have a file called |
When running the bzl_library Gazelle plugin over https://github.com/kythe/kythe/blob/master/tools/build_rules/verifier_test/BUILD it ends up modifying that file to just delete the
srcs
attribute from the respectivebzl_library
targets and it's not obvious to me why.The text was updated successfully, but these errors were encountered: