same directory and different package protos are not handled properly by gazelle

[aaomidi]

What version of gazelle are you using? 0.25.0

What version of rules_go are you using? 0.31.0

What version of Bazel are you using? 5.1.0

Does this issue reproduce with the latest releases of all the above?

Yes

What operating system and processor architecture are you using?

Linux AMD64

What did you do?

Proof of concept repo: https://github.com/aaomidi/gazelle-proto-poc

Create two proto files, in the same directory, with different packages. Depend from one proto file to another. Run gazelle fix .. It will not add the deps value. If I manually add the correct deps value, the protos build fine. However, if I run gazelle fix again, it will remove that line.

What did you expect to see?

Either handle the same directory-different package situation, or give an error/warning that protos in the same directory can't have different packages.

What did you see instead?

Either silently fails, or removes the deps file and breaks the BUILD file.

[nickgooding]

This sounds like it could be caused by the same problem as #1219. Could you see if your issue is fixed by patching the v0.25.0 release with a cherry-pick of 0408bc8?